|
| 1 | +From 021572de93b364825955073af6493012aac375ac Mon Sep 17 00:00:00 2001 |
| 2 | +From: Xabier Rodriguez Calvar < [email protected]> |
| 3 | +Date: Wed, 3 May 2023 13:21:23 +0200 |
| 4 | +Subject: [PATCH] qtdemux: emit no-more-pads after pruning old pads |
| 5 | + |
| 6 | +If we don't do that, clients can rely on this signal to see the final pad |
| 7 | +topology but it won't be the real one as some of them will disappear after |
| 8 | +emitting that signal. This can happen after injecting a different init segment. |
| 9 | + |
| 10 | +Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4535> |
| 11 | +--- |
| 12 | + gst/isomp4/qtdemux.c | 4 ++-- |
| 13 | + 1 file changed, 2 insertions(+), 2 deletions(-) |
| 14 | + |
| 15 | +diff --git a/gst/isomp4/qtdemux.c b/gst/isomp4/qtdemux.c |
| 16 | +index a872a69090..361d6e2535 100644 |
| 17 | +--- a/gst/isomp4/qtdemux.c |
| 18 | ++++ b/gst/isomp4/qtdemux.c |
| 19 | +@@ -14372,8 +14372,6 @@ qtdemux_expose_streams (GstQTDemux * qtdemux) |
| 20 | + |
| 21 | + gst_qtdemux_guess_bitrate (qtdemux); |
| 22 | + |
| 23 | +- gst_element_no_more_pads (GST_ELEMENT_CAST (qtdemux)); |
| 24 | +- |
| 25 | + /* If we have still old_streams, it's no more used stream */ |
| 26 | + for (i = 0; i < qtdemux->old_streams->len; i++) { |
| 27 | + QtDemuxStream *stream = QTDEMUX_NTH_OLD_STREAM (qtdemux, i); |
| 28 | +@@ -14391,6 +14389,8 @@ qtdemux_expose_streams (GstQTDemux * qtdemux) |
| 29 | + |
| 30 | + g_ptr_array_set_size (qtdemux->old_streams, 0); |
| 31 | + |
| 32 | ++ gst_element_no_more_pads (GST_ELEMENT_CAST (qtdemux)); |
| 33 | ++ |
| 34 | + /* check if we should post a redirect in case there is a single trak |
| 35 | + * and it is a redirecting trak */ |
| 36 | + if (QTDEMUX_N_STREAMS (qtdemux) == 1 && |
| 37 | +-- |
| 38 | +2.39.2 |
| 39 | + |
0 commit comments