Skip to content

Commit c158dfc

Browse files
authored
Hide more things behind verbose flag. (#84)
1 parent 23a63cd commit c158dfc

File tree

4 files changed

+35
-18
lines changed

4 files changed

+35
-18
lines changed

gateway_addon/adapter.py

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def __init__(self, _id, package_name, verbose=False):
3434
# False in its constructor.
3535
self.ready = True
3636

37+
self.verbose = verbose
3738
self.manager_proxy = \
3839
AddonManagerProxy(self.package_name, verbose=verbose)
3940
self.manager_proxy.add_adapter(self)
@@ -60,7 +61,8 @@ def send_error(self, message):
6061

6162
def dump(self):
6263
"""Dump the state of the adapter to the log."""
63-
print('Adapter:', self.name, '- dump() not implemented')
64+
if self.verbose:
65+
print('Adapter:', self.name, '- dump() not implemented')
6466

6567
def get_id(self):
6668
"""
@@ -166,7 +168,8 @@ def start_pairing(self, timeout):
166168
167169
timeout -- Timeout in seconds at which to quit pairing
168170
"""
169-
print('Adapter:', self.name, 'id', self.id, 'pairing started')
171+
if self.verbose:
172+
print('Adapter:', self.name, 'id', self.id, 'pairing started')
170173

171174
def send_pairing_prompt(self, prompt, url=None, device=None):
172175
"""
@@ -190,7 +193,8 @@ def send_unpairing_prompt(self, prompt, url=None, device=None):
190193

191194
def cancel_pairing(self):
192195
"""Cancel the pairing process."""
193-
print('Adapter:', self.name, 'id', self.id, 'pairing cancelled')
196+
if self.verbose:
197+
print('Adapter:', self.name, 'id', self.id, 'pairing cancelled')
194198

195199
def remove_thing(self, device_id):
196200
"""
@@ -200,8 +204,9 @@ def remove_thing(self, device_id):
200204
"""
201205
device = self.get_device(device_id)
202206
if device:
203-
print('Adapter:', self.name, 'id', self.id,
204-
'remove_thing(' + device.id + ')')
207+
if self.verbose:
208+
print('Adapter:', self.name, 'id', self.id,
209+
'remove_thing(' + device.id + ')')
205210

206211
self.handle_device_removed(device)
207212

@@ -212,13 +217,14 @@ def cancel_remove_thing(self, device_id):
212217
device_id -- ID of device to cancel unpairing with
213218
"""
214219
device = self.get_device(device_id)
215-
if device:
220+
if device and self.verbose:
216221
print('Adapter:', self.name, 'id', self.id,
217222
'cancel_remove_thing(' + device.id + ')')
218223

219224
def unload(self):
220225
"""Perform any necessary cleanup before adapter is shut down."""
221-
print('Adapter:', self.name, 'unloaded')
226+
if self.verbose:
227+
print('Adapter:', self.name, 'unloaded')
222228

223229
def set_pin(self, device_id, pin):
224230
"""
@@ -229,8 +235,9 @@ def set_pin(self, device_id, pin):
229235
"""
230236
device = self.get_device(device_id)
231237
if device:
232-
print('Adapter:', self.name, 'id', self.id,
233-
'set_pin(' + device.id + ', ' + pin + ')')
238+
if self.verbose:
239+
print('Adapter:', self.name, 'id', self.id,
240+
'set_pin(' + device.id + ', ' + pin + ')')
234241
else:
235242
raise SetPinError('Device not found')
236243

@@ -244,8 +251,9 @@ def set_credentials(self, device_id, username, password):
244251
"""
245252
device = self.get_device(device_id)
246253
if device:
247-
print('Adapter:', self.name, 'id', self.id,
248-
'set_credentials(' + device.id + ', ' + username + ', ' +
249-
password + ')')
254+
if self.verbose:
255+
print('Adapter:', self.name, 'id', self.id,
256+
'set_credentials(' + device.id + ', ' + username + ', ' +
257+
password + ')')
250258
else:
251259
raise SetCredentialsError('Device not found')

gateway_addon/api_handler.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ def __init__(self, package_name, verbose=False):
2525
"""
2626
self.package_name = package_name
2727

28+
self.verbose = verbose
2829
self.manager_proxy = \
2930
AddonManagerProxy(self.package_name, verbose=verbose)
3031
self.manager_proxy.add_api_handler(self)
@@ -63,9 +64,13 @@ def handle_request(self, request):
6364
6465
request -- APIRequest object
6566
"""
66-
print('New API request for {}: {}'.format(self.package_name, request))
67+
if self.verbose:
68+
print('New API request for {}: {}'
69+
.format(self.package_name, request))
70+
6771
return APIResponse(status=404)
6872

6973
def unload(self):
7074
"""Perform any necessary cleanup before handler is shut down."""
71-
print('API Handler:', self.package_name, 'unloaded')
75+
if self.verbose:
76+
print('API Handler:', self.package_name, 'unloaded')

gateway_addon/notifier.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ def __init__(self, _id, package_name, verbose=False):
3232
# False in its constructor.
3333
self.ready = True
3434

35+
self.verbose = verbose
3536
self.manager_proxy = \
3637
AddonManagerProxy(self.package_name, verbose=verbose)
3738
self.manager_proxy.add_notifier(self)
@@ -58,7 +59,8 @@ def send_error(self, message):
5859

5960
def dump(self):
6061
"""Dump the state of the notifier to the log."""
61-
print('Notifier:', self.name, '- dump() not implemented')
62+
if self.verbose:
63+
print('Notifier:', self.name, '- dump() not implemented')
6264

6365
def get_id(self):
6466
"""
@@ -144,4 +146,5 @@ def handle_outlet_removed(self, outlet):
144146

145147
def unload(self):
146148
"""Perform any necessary cleanup before notifier is shut down."""
147-
print('Notifier:', self.name, 'unloaded')
149+
if self.verbose:
150+
print('Notifier:', self.name, 'unloaded')

gateway_addon/outlet.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,6 @@ def notify(self, title, message, level):
5656
message -- message of notification
5757
level -- alert level
5858
"""
59-
print('Outlet: {} notify("{}", "{}", {})'
60-
.format(self.name, title, message, level))
59+
if self.notifier.verbose:
60+
print('Outlet: {} notify("{}", "{}", {})'
61+
.format(self.name, title, message, level))

0 commit comments

Comments
 (0)