Skip to content

Commit 3ff66f5

Browse files
committed
docs(android): TODO to extract repeated buildTrackParams block into helper
1 parent 583b3dc commit 3ff66f5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

android/src/main/java/com/cloudwebrtc/webrtc/GetUserMediaImpl.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -889,6 +889,7 @@ private ConstraintsMap buildSharedVideoTrack(VideoCapturerInfoEx primary, String
889889
mediaStream.addTrack(track);
890890
stateProvider.putLocalTrack(track.id(), new LocalVideoTrack(track));
891891

892+
// TODO: extract into a helper method - same block (enabled, id, kind, label, readyState, remote) repeated in getUserAudio() and getUserVideo()
892893
ConstraintsMap trackParams = new ConstraintsMap();
893894
trackParams.putBoolean("enabled", track.enabled());
894895
trackParams.putString("id", track.id());
@@ -897,6 +898,7 @@ private ConstraintsMap buildSharedVideoTrack(VideoCapturerInfoEx primary, String
897898
trackParams.putString("readyState", track.state().toString());
898899
trackParams.putBoolean("remote", false);
899900

901+
// TODO: extract into a helper method - same block (deviceId, kind, width, height, frameRate) repeated in getUserVideo()
900902
ConstraintsMap settings = new ConstraintsMap();
901903
settings.putString("deviceId", primary.cameraName != null ? primary.cameraName : "");
902904
settings.putString("kind", "videoinput");

0 commit comments

Comments
 (0)