refactor(portaswitch): simplify token handling with version check helper function

Author: yakimenko73

app/bss/adapters/portaswitch/adapter.py

@@ -162,14 +162,8 @@ def authenticate(self, user: UserInfo, password: str = None) -> SessionInfo:
             if self._portaswitch_settings.ALLOWED_ADDONS:
                 self._check_allowed_addons(account_info)
 
-            version = self._admin_api.get_version()
-            actual_portaswitch_mr = [int(d) for d in re.findall(r'\d+', version)]
-            expected_portaswitch_mr_with_token_support = [int(d) for d in
-                                                          re.findall(r'\d+', PORTASWITCH_VERSION_WITH_TOKEN)]
-
-            token = account_info["password"]
-            session_data = self._account_api.login(account_info["login"], account_info["password"],
-                                                   token if actual_portaswitch_mr < expected_portaswitch_mr_with_token_support else None)
+            token = account_info["password"] if self._is_portaswitch_version_with_token() else None
+            session_data = self._account_api.login(account_info["login"], account_info["password"], token)
 
             return SessionInfo(
                 user_id=UserId(str(account_info["i_account"])),
@@ -1428,4 +1422,14 @@ def _emulate_account_login(self, i_account: str) -> dict:
         """Emulate a login for a PortaSwitch account."""
         account_info = self._admin_api.get_account_info(i_account=i_account).get("account_info")
 
-        return self._account_api.login(account_info["login"], account_info["password"])
+        token = account_info["password"] if self._is_portaswitch_version_with_token() else None
+        return self._account_api.login(account_info["login"], account_info["password"], token)
+
+    def _is_portaswitch_version_with_token(self) -> bool:
+        """Check if the actual version of PortaSwitch is a version with token support."""
+        version = self._admin_api.get_version()
+        actual_portaswitch_mr = [int(d) for d in re.findall(r'\d+', version)]
+        expected_portaswitch_mr_with_token_support = [int(d) for d in
+                                                      re.findall(r'\d+', PORTASWITCH_VERSION_WITH_TOKEN)]
+
+        return actual_portaswitch_mr < expected_portaswitch_mr_with_token_support