fix: wrap full renegotiation sequence in try/catch, update error context, add unawaited

Author: SERDUN

lib/features/call/bloc/call_bloc.dart

@@ -2784,7 +2784,8 @@ class CallBloc extends Bloc<CallEvent, CallState> with WidgetsBindingObserver im
         onIceCandidate: (candidate) => add(_PeerConnectionEvent.iceCandidateIdentified(callId, candidate)),
         onAddStream: (stream) => add(_PeerConnectionEvent.streamAdded(callId, stream)),
         onRemoveStream: (stream) => add(_PeerConnectionEvent.streamRemoved(callId, stream)),
-        onRenegotiationNeeded: (pc) => _renegotiationHandler.handle(callId, lineId, pc, _sendRenegotiationUpdate),
+        onRenegotiationNeeded: (pc) =>
+            unawaited(_renegotiationHandler.handle(callId, lineId, pc, _sendRenegotiationUpdate)),
       ),
     );
   }

lib/features/call/utils/renegotiation_handler.dart

@@ -23,26 +23,26 @@ class RenegotiationHandler {
     final stateBeforeOffer = peerConnection.signalingState;
     _logger.fine(() => 'onRenegotiationNeeded signalingState: $stateBeforeOffer');
     if (stateBeforeOffer == RTCSignalingState.RTCSignalingStateStable) {
-      final localDescription = await peerConnection.createOffer({});
-      sdpMunger?.apply(localDescription);
-
-      final stateAfterOffer = peerConnection.signalingState;
-      if (stateAfterOffer != RTCSignalingState.RTCSignalingStateStable) {
-        _logger.fine(
-          () =>
-              'onRenegotiationNeeded: state changed to $stateAfterOffer after createOffer, skipping setLocalDescription',
-        );
-        return;
-      }
-
-      // According to RFC 8829 5.6 (https://datatracker.ietf.org/doc/html/rfc8829#section-5.6),
-      // localDescription should be set before sending the offer to transition into have-local-offer state.
-      await peerConnection.setLocalDescription(localDescription);
-
       try {
+        final localDescription = await peerConnection.createOffer({});
+        sdpMunger?.apply(localDescription);
+
+        final stateAfterOffer = peerConnection.signalingState;
+        if (stateAfterOffer != RTCSignalingState.RTCSignalingStateStable) {
+          _logger.fine(
+            () =>
+                'onRenegotiationNeeded: state changed to $stateAfterOffer after createOffer, skipping setLocalDescription',
+          );
+          return;
+        }
+
+        // According to RFC 8829 5.6 (https://datatracker.ietf.org/doc/html/rfc8829#section-5.6),
+        // localDescription should be set before sending the offer to transition into have-local-offer state.
+        await peerConnection.setLocalDescription(localDescription);
+
         await execute(callId, lineId, localDescription);
       } catch (e, s) {
-        callErrorReporter.handle(e, s, '_createPeerConnection:onRenegotiationNeeded error');
+        callErrorReporter.handle(e, s, 'RenegotiationHandler.handle error (callId=$callId, lineId=$lineId)');
       }
     }
   }

test/features/call/utils/renegotiation_handler_test.dart

@@ -151,12 +151,14 @@ void main() {
   });
 
   group('RenegotiationHandler — execute error handling', () {
+    setUp(() {
+      when(() => mockErrorReporter.handle(any(), any(), any())).thenReturn(null);
+    });
+
     test('reports error via callErrorReporter when execute throws', () async {
       when(() => mockPC.signalingState).thenReturn(RTCSignalingState.RTCSignalingStateStable);
       when(() => mockPC.createOffer(any())).thenAnswer((_) async => kOffer);
       when(() => mockPC.setLocalDescription(any())).thenAnswer((_) async {});
-      when(() => mockErrorReporter.handle(any(), any(), any())).thenReturn(null);
-
       handler = RenegotiationHandler(callErrorReporter: mockErrorReporter);
       final exception = Exception('signaling error');
 
@@ -165,12 +167,33 @@ void main() {
       verify(() => mockErrorReporter.handle(exception, any(), any())).called(1);
     });
 
+    test('reports error via callErrorReporter when createOffer throws', () async {
+      when(() => mockPC.signalingState).thenReturn(RTCSignalingState.RTCSignalingStateStable);
+      final exception = Exception('createOffer error');
+      when(() => mockPC.createOffer(any())).thenThrow(exception);
+      handler = RenegotiationHandler(callErrorReporter: mockErrorReporter);
+
+      await handler.handle(kCallId, kLineId, mockPC, (_, _, _) async {});
+
+      verify(() => mockErrorReporter.handle(exception, any(), any())).called(1);
+    });
+
+    test('reports error via callErrorReporter when setLocalDescription throws', () async {
+      when(() => mockPC.signalingState).thenReturn(RTCSignalingState.RTCSignalingStateStable);
+      when(() => mockPC.createOffer(any())).thenAnswer((_) async => kOffer);
+      final exception = Exception('setLocalDescription error');
+      when(() => mockPC.setLocalDescription(any())).thenThrow(exception);
+      handler = RenegotiationHandler(callErrorReporter: mockErrorReporter);
+
+      await handler.handle(kCallId, kLineId, mockPC, (_, _, _) async {});
+
+      verify(() => mockErrorReporter.handle(exception, any(), any())).called(1);
+    });
+
     test('does not rethrow when execute throws', () async {
       when(() => mockPC.signalingState).thenReturn(RTCSignalingState.RTCSignalingStateStable);
       when(() => mockPC.createOffer(any())).thenAnswer((_) async => kOffer);
       when(() => mockPC.setLocalDescription(any())).thenAnswer((_) async {});
-      when(() => mockErrorReporter.handle(any(), any(), any())).thenReturn(null);
-
       handler = RenegotiationHandler(callErrorReporter: mockErrorReporter);
 
       await expectLater(