Merge pull request #60 from WebView-CG/baseline

Show partial support for web-features and add notes for unsupported keys in BCD calculations

Author: NiklasMerz

.github/workflows/update_version.yml

@@ -26,6 +26,7 @@ jobs:
           git config user.name github-actions
           git config user.email [email protected]
           git add bcd_version
+          git add package-lock.json
           git diff --quiet && git diff --staged --quiet || git commit -m "Update bcd version"
           git push
       - name: Notify failed build

_js/compare.js

@@ -299,7 +299,7 @@ permalink: "/assets/js/compare.js"
 			let features = this.buildFeaturesBySupportObject();
 			this.buildResultsAsTable(features.m, 'Mixed support');
 			this.buildResultsAsTags(features.y, 'Supported', 'supported');
-			this.buildResultsAsTags(features.a, 'Partial support', 'mitigated');
+			this.buildResultsAsTags(features.a, 'Partial support', 'partial');
 			this.buildResultsAsTags(features.n, 'Not supported', 'unsupported');
 			this.buildResultsAsTags(features.u, 'Support unknown', 'unknown');
 		}

_layouts/feature.html

@@ -176,20 +176,27 @@ <h4 class="data-platform-name">
 		<div class="data-notes">
 			{% if has-page-notes == true or page.notes_by_num.size > 0 %}
 			<h2 class="list-title">Notes</h2>
-			{% if has-page-notes == true %}
-			{{ page.notes | markdownify }}
-			{% endif %}
 			{% if page.notes_by_num.size > 0 %}
+			<h3 class="list-subtitle">Unsupported keys in WebViews</h3>
 			<ul class="data-notes-list">
 				{% for note in page.notes_by_num %}
 				{% assign note-key = note | first %}
 				{% assign note-value = note | last %}
 				<li class="data-note" id="{{ page.slug }}-cite-note-{{ note-key | slugify }}">
-					<span class="data-note-key">{{ note-key }}</span> {{ note-value | markdownify }}
+					<b>{{ site.data.nicenames.family[note-key] }}:</b>
+					<div class="note-tags">
+						{% assign note-items = note-value | split: ',' %}
+						{% for item in note-items %}
+							<span class="tag unsupported">{{ item | strip }}</span>
+						{% endfor %}
+					</div>
 				</li>
 				{% endfor %}
 			</ul>
 			{% endif %}
+			{% if has-page-notes == true %}
+			{{ page.notes | markdownify }}
+			{% endif %}
 			{% endif %}
 			{% if page.links.size > 0 %}
 			<h2 class="list-title">Resources</h2>

_plugins/generated_features.rb

@@ -153,11 +153,12 @@ def generate_baseline(site)
 			doc.data['description'] = feature['description']
 			doc.data['slug'] = feature['slug']
 			doc.data['category'] = feature['category']
-			doc.data['keywords'] = 'todo'
+			doc.data['keywords'] = 'baseline'
 			doc.data['last_test_date'] = feature['last_test_date']
 			doc.data['notes'] = data_source
 			doc.data['links'] = feature['links']
 			doc.data['stats'] = feature['stats']
+			doc.data['notes_by_num'] = feature['notes_by_num']
 			doc.data['baseline'] = feature['baseline']
 
 			site.collections['generated_features'].docs << doc

_sass/_pages/_feature.scss

@@ -200,6 +200,10 @@
 	background-color: #eda745 !important;
 }
 
+.partially-header {
+	color: #eda745 !important;
+}
+
 .score .mitigated {
 	background-image: repeating-linear-gradient(
 		-45deg,
@@ -678,6 +682,17 @@
 	}
 }
 
+.note-tags {
+	display: inline-flex;
+	flex-wrap: wrap;
+	gap: rem(4px);
+	margin-top: rem(4px);
+
+	.tag {
+		font-size: rem(14px);
+	}
+}
+
 .data-note-key {
 	display: flex;
 	justify-content: center;