Skip to content

Commit 5957492

Browse files
chore: add aria-label and title attributes in Contributors and Teams Card Pages (#498)
* update Bugs/Issues for Social Icons in Contributors and Teams Card Pages * Update src/components/ContributorCard.tsx I accepted your Suggestions Co-authored-by: Anmol Baranwal <[email protected]> * Update src/components/ContributorCard.tsx I accepted your Valuable Suggestions Co-authored-by: Anmol Baranwal <[email protected]> * Update src/components/ContributorCard.tsx I accepted your Valuable suggestions Co-authored-by: Anmol Baranwal <[email protected]> --------- Co-authored-by: Anmol Baranwal <[email protected]>
1 parent 05e6c89 commit 5957492

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

src/components/ContributorCard.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,18 @@ export default function ContributorCard({ data }: { data: Card }) {
3434
className="rounded-full border"
3535
/>
3636
<div className="mb-2 flex gap-12 text-2xl">
37-
<Link href={data.html_url} target="_blank" className="duration-150 hover:text-[#411AFF]">
37+
<Link href={data.html_url} target="_blank"
38+
aria-label="GitHub Profile"
39+
title="GitHub (External Link)"
40+
rel="noopener noreferrer" className="duration-150 hover:text-[#411AFF]">
3841
<FaGithub />
3942
</Link>
4043
<Link
4144
href={`https://github.com/WebXDAO/WebXDAO.github.io/commits?author=${data.login}`}
4245
target="_blank"
46+
aria-label="Visit Code Contributions"
47+
title="Code Contributions (External Link)"
48+
rel="noopener noreferrer"
4349
className="duration-150 hover:text-[#411AFF]"
4450
>
4551
<FaLaptopCode />

src/components/TeamCard.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,30 @@ const TeamCard = ({
2121
<h1 className="my-1 text-center">{Name}</h1>
2222
<h2 className="my-1 text-center">{position}</h2>
2323
<div className="my-6 flex place-content-center gap-4 px-5">
24-
<Link href={github_url} target="_blank">
24+
<Link href={github_url} target="_blank"
25+
aria-label="Visit us on GitHub"
26+
title="GitHub (External Link)"
27+
rel="noopener noreferrer">
2528
<Icons.gitHub
2629
className="cursor-pointer transition duration-500 hover:scale-150 hover:fill-blue-800"
2730
width={25}
2831
height={25}
2932
/>
3033
</Link>
31-
<Link href={twitter_url} target="_blank">
34+
<Link href={twitter_url} target="_blank"
35+
aria-label="Visit us on Twitter"
36+
title="Twitter (External Link)"
37+
rel="noopener noreferrer">
3238
<Icons.twitter
3339
className="cursor-pointer transition duration-500 hover:scale-150 hover:fill-blue-800"
3440
width={25}
3541
height={25}
3642
/>
3743
</Link>
38-
<Link href={linkedin_url} target="_blank">
44+
<Link href={linkedin_url} target="_blank"
45+
aria-label="Visit us on Linkedin"
46+
title="Linkedin (External Link)"
47+
rel="noopener noreferrer">
3948
<Icons.linkedin
4049
className="cursor-pointer transition duration-500 hover:scale-150 hover:fill-blue-800"
4150
width={25}

0 commit comments

Comments
 (0)