Implemented PHPCompatibilityWP

Author: ajaydsouza

composer.json

@@ -11,7 +11,8 @@
         "support",
         "documentation"
     ],
-    "license": "GPL-2.0-or-later",
+    "license": "gpl-2.0-or-later",
+    "homepage": "https://webberzone.com/plugins/knowledgebase/",
     "authors": [
         {
             "name": "WebberZone",
@@ -24,10 +25,12 @@
     "require-dev": {
         "szepeviktor/phpstan-wordpress": "^1",
         "phpstan/extension-installer": "^1",
+        "phpstan/phpstan": "^1",
         "php-stubs/wordpress-stubs": "^6",
         "wp-coding-standards/wpcs": "^3",
         "dealerdirect/phpcodesniffer-composer-installer": "^1",
-        "phpcompatibility/phpcompatibility-wp": "^2",
+        "phpcompatibility/phpcompatibility-wp": "*",
+        "phpcompatibility/php-compatibility": "dev-develop as 9.99.99",
         "yoast/phpunit-polyfills": "^3",
         "phpunit/phpunit": "^9 || ^10 || ^11 || ^12"
     },
@@ -37,6 +40,8 @@
             "dealerdirect/phpcodesniffer-composer-installer": true
         }
     },
+    "minimum-stability": "dev",
+    "prefer-stable": true,
     "scripts": {
         "phpstan": "vendor/bin/phpstan analyse --memory-limit=2048M",
         "phpstan-baseline": "vendor/bin/phpstan analyse --memory-limit=2048M --generate-baseline",

includes/admin/settings/class-metabox-api.php

@@ -331,7 +331,7 @@ public function sanitize_post_meta( $settings ) {
 				$ids   = array();
 				$names = array();
 
-				$taxes = array_unique( str_getcsv( $settings[ $key ] ) );
+				$taxes = array_unique( str_getcsv( $settings[ $key ], ',', '"', '' ) );
 
 				foreach ( $taxes as $tax ) {
 					$tax_name = get_term_by( 'name', $tax, $fields['tax'] );

includes/admin/settings/class-settings-api.php

@@ -418,8 +418,6 @@ public function add_custom_menu_page( $menu ) {
 	 * Add admin menu.
 	 */
 	public function admin_menu() {
-		global ${$this->prefix . '_menu_pages'};
-
 		foreach ( $this->menus as $menu ) {
 			$menu_page = $this->add_custom_menu_page( $menu );
 
@@ -428,7 +426,6 @@ public function admin_menu() {
 				$this->settings_page = $menu_page;
 			}
 		}
-		${$this->prefix . '_menu_pages'} = $this->menu_pages;
 
 		// Load the settings contextual help.
 		add_action( 'load-' . $this->settings_page, array( $this, 'settings_help' ) );

includes/admin/settings/class-settings-sanitize.php

@@ -416,7 +416,7 @@ public static function str_putcsv( $input_array, $delimiter = ',', $enclosure =
 	 */
 	public static function sanitize_tax_slugs( &$settings, $source_key, $target_key ) {
 		if ( isset( $settings[ $source_key ] ) ) {
-			$slugs = array_unique( str_getcsv( $settings[ $source_key ] ) );
+			$slugs = array_unique( str_getcsv( $settings[ $source_key ], ',', '"', '' ) );
 
 			foreach ( $slugs as $slug ) {
 				// Pattern is Name (taxonomy:term_taxonomy_id).

phpcs.xml.dist

@@ -37,4 +37,8 @@
 	<rule ref="Generic.Commenting.Todo"/>
 	<rule ref="Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed"/>
 
+	<!-- Check for PHP 7.4+ compatibility. -->
+	<config name="testVersion" value="7.4-"/>
+	<rule ref="PHPCompatibilityWP"/>
+
 </ruleset>