Add flake8 configuration file and correct reported linting errors

Author: cmlccie

.flake8

@@ -0,0 +1,9 @@
+[flake8]
+ignore = E402,F401,F403
+exclude =
+    .git,
+    __pycache__,
+    ciscosparkapi/_version.py,
+    docs/source/conf.py,
+    build,
+    dist,

ciscosparkapi/__init__.py

@@ -22,7 +22,10 @@
 from ciscosparkapi.api.memberships import Membership, MembershipsAPI
 from ciscosparkapi.api.messages import Message, MessagesAPI
 from ciscosparkapi.api.teams import Team, TeamsAPI
-from ciscosparkapi.api.teammemberships import TeamMembership, TeamMembershipsAPI
+from ciscosparkapi.api.teammemberships import (
+    TeamMembership,
+    TeamMembershipsAPI
+)
 from ciscosparkapi.api.webhooks import Webhook, WebhooksAPI
 from ciscosparkapi.api.organizations import Organization, OrganizationsAPI
 from ciscosparkapi.api.licenses import License, LicensesAPI

ciscosparkapi/api/rooms.py

@@ -147,7 +147,7 @@ def list(self, max=None, **query_params):
         params = {}
         if max:
             params['max'] = max
-        # Process query_param keyword arguments 
+        # Process query_param keyword arguments
         if query_params:
             params.update(query_params)
         # API request - get items

ciscosparkapi/api/teammemberships.py

@@ -243,7 +243,7 @@ def update(self, membershipId, **update_attributes):
             raise ciscosparkapiException(error_message)
         # API request
         json_obj = self._session.put('team/memberships/' + membershipId,
-                                      json=update_attributes)
+                                     json=update_attributes)
         # Return a TeamMembership object created from the response JSON data
         return TeamMembership(json_obj)
 

ciscosparkapi/api/teams.py

@@ -189,7 +189,8 @@ def update(self, teamId, **update_attributes):
                             "argument must be specified."
             raise ciscosparkapiException(error_message)
         # API request
-        json_obj = self._session.post('teams/' + teamId, json=update_attributes)
+        json_obj = self._session.post('teams/' + teamId,
+                                      json=update_attributes)
         # Return a Team object created from the response JSON data
         return Team(json_obj)
 

ciscosparkapi/sparkdata.py

@@ -14,7 +14,11 @@
 to objects by the Cisco Spark cloud.
 
 Example:
-    >>> json_obj = '{"created": "2012-06-15T20:36:48.914Z", "displayName": "Chris Lunsford (chrlunsf)", "id": "Y2lzY29zcGFyazovL3VzL1BFT1BMRS9mZjhlZTZmYi1hZmVmLTRhNGQtOTJiMS1kNmIyMTZiNTg5NDk", "avatar": "https://1efa7a94ed216783e352-c62266528714497a17239ececf39e9e2.ssl.cf1.rackcdn.com/V1~ba1ecf557a7e0b7cc3081998df965aad~cNFKqEjAQ5aQkyt_l1zsCQ==~1600", "emails": ["[email protected]"]}'
+    >>> json_obj = '{"created": "2012-06-15T20:36:48.914Z",
+                     "displayName": "Chris Lunsford (chrlunsf)",
+                     "id": "Y2lzY29zcGFyazovL3VzL1BFT1BMRS9mZjhlZTZmYi1hZm...",
+                     "avatar": "https://1efa7a94ed216783e352-c622665287144...",
+                     "emails": ["[email protected]"]}'
     >>> python_obj = SparkData(json_obj)
     >>> python_obj.displayName
     u'Chris Lunsford (chrlunsf)'

ciscosparkapi/utils.py

@@ -54,12 +54,9 @@ def is_web_url(string):
     """Check to see if string is an validly-formatted web url."""
     assert isinstance(string, str)
     parsed_url = urllib.parse.urlparse(string)
-    if (parsed_url.scheme.lower() == 'http' \
-        or parsed_url.scheme.lower() == 'https') \
-        and parsed_url.netloc:
-        return True
-    else:
-        return False
+    return ((parsed_url.scheme.lower() == 'http' or
+             parsed_url.scheme.lower() == 'https') and
+            parsed_url.netloc)
 
 
 def is_local_file(string):