Skip to content

Commit 9bbbd0e

Browse files
committed
Change page_size to 1 in test_list_rooms_with_paging
There is no need for each ‘page’ to contain more than a single item. This may help minimize the number of test rooms created, which will help minimize the number of API calls that must be made to create and delete these test rooms.
1 parent 49c6fae commit 9bbbd0e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

tests/api/test_rooms.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,14 @@ def temp_group_room(api):
7878
@pytest.fixture
7979
def add_rooms(api):
8080
rooms = []
81+
8182
def inner(num_rooms):
8283
for i in range(num_rooms):
8384
rooms.append(create_room(api, create_string("Additional Room")))
8485
return rooms
86+
8587
yield inner
88+
8689
for room in rooms:
8790
delete_room(api, room)
8891

@@ -132,7 +135,7 @@ def test_list_all_rooms(self, rooms_list):
132135
assert are_valid_rooms(rooms_list)
133136

134137
def test_list_rooms_with_paging(self, api, rooms_list, add_rooms):
135-
page_size = 2
138+
page_size = 1
136139
pages = 3
137140
num_rooms = pages * page_size
138141
if len(rooms_list) < num_rooms:

0 commit comments

Comments
 (0)