Skip to content

Commit f53d736

Browse files
committed
Optimize dependencies for authenticated_user_memberships
Add group_room, team_room, and direct_rooms dependencies to authenticated_user_memberships and remove them from tests that depend on authenticated_user_memberships.
1 parent 93c18cf commit f53d736

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

tests/api/test_memberships.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def delete_membership(api, membership):
5151

5252

5353
def empty_room(api, me, room):
54-
"""Remove all memberships from a room (except the caller's membership)."""
54+
"""Remove all memberships from a room (except me)."""
5555
memberships = api.memberships.list(room.id)
5656
for membership in memberships:
5757
if membership.personId != me.id:
@@ -88,7 +88,7 @@ def my_group_room_membership(api, me, group_room):
8888

8989

9090
@pytest.fixture(scope="session")
91-
def authenticated_user_memberships(api):
91+
def authenticated_user_memberships(api, group_room, team_room, direct_rooms):
9292
return list(api.memberships.list())
9393

9494

@@ -168,16 +168,13 @@ def test_get_membership_details(self, api, my_group_room_membership):
168168
membership = get_membership_by_id(api, my_group_room_membership.id)
169169
assert is_valid_membership(membership)
170170

171-
def test_list_user_memberships(self, group_room, team_room, direct_rooms,
172-
authenticated_user_memberships):
171+
def test_list_user_memberships(self, authenticated_user_memberships):
173172
assert len(authenticated_user_memberships) >= 3
174173
assert are_valid_memberships(authenticated_user_memberships)
175174

176175
def test_list_user_memberships_with_paging(self, api, add_rooms,
177-
authenticated_user_memberships,
178-
group_room, team_room,
179-
direct_rooms):
180176
page_size = 2
177+
authenticated_user_memberships):
181178
pages = 3
182179
num_memberships = pages * page_size
183180
if len(authenticated_user_memberships) < num_memberships:

0 commit comments

Comments
 (0)