workflow with lint and docker build-push (deckhouse#39)

Also fixed linter warnings

Author: 31337Ghost

.github/workflows/ci.yml

@@ -0,0 +1,55 @@
+name: CI
+on:
+  push:
+    tags:
+      - v*
+    branches:
+     - master
+  pull_request:
+    branches:
+      - master
+env:
+  REGISTRY: registry-write.deckhouse.io
+  IMAGE_NAME: k8s-image-availability-exporter/k8s-image-availability-exporter
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    if: github.event_name == 'pull_request'
+    steps:
+      - uses: actions/checkout@v2
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: v1.42
+  build:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      packages: write
+    steps:
+      - uses: actions/checkout@v2
+      # Login against a Docker registry except on PR
+      # https://github.com/docker/login-action
+      - name: Log into registry ${{ env.REGISTRY }}
+        if: github.event_name != 'pull_request'
+        uses: docker/login-action@28218f9b04b4f3f62068d7b6ce6ca5b26e35336c
+        with:
+          registry: ${{ env.REGISTRY }}
+          username: ${{ secrets.DECKHOUSE_REGISTRY_USER }}
+          password: ${{ secrets.DECKHOUSE_REGISTRY_PASSWORD }}
+      # Extract metadata (tags, labels) for Docker
+      # https://github.com/docker/metadata-action
+      - name: Extract Docker metadata
+        id: meta
+        uses: docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38
+        with:
+          images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
+      # Build and push Docker image with Buildx (don't push on PR)
+      # https://github.com/docker/build-push-action
+      - name: Build and push Docker image
+        uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
+        with:
+          context: .
+          push: ${{ github.event_name != 'pull_request' }}
+          tags: ${{ steps.meta.outputs.tags }}
+          labels: ${{ steps.meta.outputs.labels }}

README.md

@@ -1,8 +1,5 @@
 # k8s-image-availability-exporter
 
-[![Docker images](https://img.shields.io/docker/cloud/automated/flant/k8s-image-availability-exporter)](https://hub.docker.com/r/flant/k8s-image-availability-exporter)
-[![Latest Docker image](https://img.shields.io/docker/v/flant/k8s-image-availability-exporter?sort=semver)](https://hub.docker.com/r/flant/k8s-image-availability-exporter)
-
 k8s-image-availability-exporter (or *k8s-iae* for short) is a Prometheus exporter that warns you proactively about images that are defined in Kubernetes objects (e.g., an `image` field in the Deployment) but are not available in the container registry (such as Docker Registry, etc.).
 
 Receiving alerts when container images related to running Kubernetes controllers are missing helps you to solve the problem before it manifests itself. For more details on the reasons behind k8s-iae and how it works, please read [this article](https://blog.flant.com/announcing-k8s-image-availability-exporter/).

deploy/deployment.yaml

@@ -27,7 +27,7 @@ spec:
           ports:
             - containerPort: 8080
               name: http-metrics
-          image: flant/k8s-image-availability-exporter:v0.1.14
+          image: registry.deckhouse.io/k8s-image-availability-exporter/k8s-image-availability-exporter:v0.1.17
           imagePullPolicy: IfNotPresent
           livenessProbe:
             httpGet:

helm/k8s-image-availability-exporter/Chart.yaml

@@ -1,5 +1,5 @@
 apiVersion: v1
-appVersion: "v0.1.14"
+appVersion: "v0.1.17"
 description: Application for monitoring the cluster workloads image presence in docker registry.
 name: k8s-image-availability-exporter
 version: "0.0.2"

helm/k8s-image-availability-exporter/values.yaml

@@ -1,7 +1,7 @@
 k8sImageAvailabilityExporter:
   image:
-    repository: flant/k8s-image-availability-exporter
-    tag: v0.1.13
+    repository: registry.deckhouse.io/k8s-image-availability-exporter/k8s-image-availability-exporter
+    tag: v0.1.17
     pullPolicy: IfNotPresent
   replicas: 1
   resources: {}

pkg/registry_checker/checker.go

@@ -22,17 +22,13 @@ import (
 	"github.com/flant/k8s-image-availability-exporter/pkg/store"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/tools/cache"
-
-	"github.com/prometheus/client_golang/prometheus"
 )
 
 const (
 	resyncPeriod = time.Hour
 )
 
 type RegistryChecker struct {
-	lock sync.RWMutex
-
 	imageStore *store.ImageStore
 
 	deploymentsInformer  appsv1informers.DeploymentInformer
@@ -45,8 +41,6 @@ type RegistryChecker struct {
 
 	ignoredImages map[string]struct{}
 
-	imageExistsVectors []prometheus.Metric
-
 	registryTransport *http.Transport
 
 	kubeClient *kubernetes.Clientset

pkg/registry_checker/image_pull.go

@@ -61,9 +61,5 @@ func IsOldRegistry(err error) bool {
 	var schemaErr *remote.ErrSchema1
 	errors.As(err, &schemaErr)
 
-	if schemaErr != nil {
-		return true
-	}
-
-	return false
+	return schemaErr != nil
 }

pkg/registry_checker/indexers.go

@@ -210,11 +210,7 @@ func (ci ControllerIndexers) GetKeysByIndex(image string) (ret []string) {
 func (ci ControllerIndexers) CheckImageExistence(image string) bool {
 	keys := ci.GetKeysByIndex(image)
 
-	if len(keys) > 0 {
-		return true
-	}
-
-	return false
+	return len(keys) > 0
 }
 
 func (ci ControllerIndexers) GetContainerInfosForImage(image string) (ret []store.ContainerInfo) {

pkg/store/image_store.go

@@ -160,7 +160,7 @@ func (imgStore *ImageStore) Length() int {
 
 func (imgStore *ImageStore) PopOldestImages(count int) (ret []string) {
 	imgStore.lock.Lock()
-	imgStore.lock.Unlock()
+	defer imgStore.lock.Unlock()
 
 	if count == 0 {
 		count = 1