feat(custmer): track vatin validation errors for existing customers

Author: nijel

weblate_web/crm/migrations/0006_alter_interaction_origin.py

@@ -0,0 +1,25 @@
+# Generated by Django 5.2.8 on 2025-12-12 07:33
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("CRM", "0005_alter_interaction_origin"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="interaction",
+            name="origin",
+            field=models.IntegerField(
+                choices=[
+                    (1, "Outbound e-mail"),
+                    (2, "Merged customer"),
+                    (3, "Attachment exchanged in Zammad"),
+                    (4, "VIES validation"),
+                ],
+                verbose_name="Origin",
+            ),
+        ),
+    ]

weblate_web/crm/models.py

@@ -14,6 +14,7 @@ class Origin(models.IntegerChoices):
         EMAIL = 1, "Outbound e-mail"
         MERGE = 2, "Merged customer"
         ZAMMAD_ATTACHMENT = 3, "Attachment exchanged in Zammad"
+        VIES = 4, "VIES validation"
 
     timestamp = models.DateTimeField(default=timezone.now, verbose_name="Timestamp")
     origin = models.IntegerField(choices=Origin, verbose_name="Origin")

weblate_web/payments/models.py

@@ -324,6 +324,18 @@ def merge(self, other: Customer, *, user: User | None = None) -> None:
         )
         other.delete()
 
+    def validate_vatin(self):
+        from weblate_web.crm.models import Interaction  # noqa: PLC0415
+
+        try:
+            validate_vatin(self.vat)
+        except ValidationError as error:
+            self.interaction_set.create(
+                origin=Interaction.Origin.VIES,
+                summary=error.code or str(error.message),
+            )
+            raise
+
 
 RECURRENCE_CHOICES = [
     ("y", gettext_lazy("Annual")),

weblate_web/payments/validators.py

@@ -54,16 +54,21 @@ def validate_vatin(value: str | VATIN) -> None:
         vatin.verify_country_code()
     except ValidationError as error:
         msg = _("{} is not a valid country code for any European Union member.")
-        raise ValidationError(msg.format(vatin.country_code)) from error
+        raise ValidationError(
+            msg.format(vatin.country_code), code="Invalid country"
+        ) from error
     try:
         vatin.verify_regex()
     except ValidationError as error:
         msg = _("{} does not match the country's VAT ID specifications.")
-        raise ValidationError(msg.format(vatin)) from error
+        raise ValidationError(msg.format(vatin), code="Invalid VAT syntax") from error
 
     if not vies_data["valid"]:
         retry_errors = {"MS_UNAVAILABLE", "MS_MAX_CONCURRENT_REQ", "TIMEOUT"}
         retry_codes = {"soap:Server", "other:Error", "env:Server"}
+        code = "{}: {}".format(
+            vies_data.get("fault_code"), vies_data.get("fault_message")
+        )
         if (
             vies_data.get("fault_message") in retry_errors
             or vies_data.get("fault_code") in retry_codes
@@ -78,4 +83,4 @@ def validate_vatin(value: str | VATIN) -> None:
             )
         else:
             msg = _("{} is not a valid VAT ID.").format(vatin)
-        raise ValidationError(msg)
+        raise ValidationError(msg, code=code)

weblate_web/views.py

@@ -87,7 +87,7 @@
 )
 from weblate_web.payments.forms import CustomerForm
 from weblate_web.payments.models import Customer, Payment
-from weblate_web.payments.validators import cache_vies_data, validate_vatin
+from weblate_web.payments.validators import cache_vies_data
 from weblate_web.remote import get_activity
 from weblate_web.utils import (
     AUTO_ORIGIN,
@@ -411,7 +411,7 @@ def validate_customer(self, customer: Customer) -> HttpResponse | None:
         # often broken, so all repeating payments without a validation
         if customer.vat and not self.object.repeat:
             try:
-                validate_vatin(customer.vat)
+                customer.validate_vatin()
             except ValidationError:
                 messages.warning(
                     self.request,