Skip to content

Commit 3cfab65

Browse files
authored
Merge pull request #6 from Webperf-se/resolved-rules
Added resolved-rules list
2 parents f79bf17 + f1ed541 commit 3cfab65

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

lib/harAnalyzer.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export class HarAnalyzer {
9494
'url': url,
9595
'group': group,
9696
'issues': [],
97-
'resolved': []
97+
'resolved-rules': []
9898
};
9999

100100
if (analyzedData === undefined) {
@@ -130,11 +130,10 @@ export class HarAnalyzer {
130130
const lintResults = await Promise.all(lintPromises);
131131
knowledgeData.issues = lintResults.flat();
132132

133-
// Sort the warnings by severity: "error" first, then "warning"
134-
// const severityOrder = { error: 1, warning: 2 };
135-
// knowledgeData.issues.sort((a, b) => {
136-
// return severityOrder[a.warning.severity] - severityOrder[b.warning.severity];
137-
// });
133+
// Populate "resolved-rules" with rules not mentioned in "issues"
134+
const allRules = Object.keys(this.config.rules);
135+
const mentionedRules = new Set(knowledgeData.issues.map(issue => issue.rule));
136+
knowledgeData['resolved-rules'] = allRules.filter(rule => !mentionedRules.has(rule));
138137
} catch (err) {
139138
}
140139

0 commit comments

Comments
 (0)