Skip to content

Commit 230360f

Browse files
author
chendelin1982
committed
fix: resolve code review issues for Story 5.5.2 RBAC API Endpoints
- Add comprehensive Dev Agent Record and File List to story documentation - Fix API endpoint path inconsistency: /permissions/my → /permissions/me - Update acceptance criteria to reflect actual implementation status - Remove redundant WriteHeader calls in error handling - Clean up git backup files and update .gitignore - Add missing test cases for duplicate member handling and pagination - Update sprint status from 'done' to 'in-progress' - Regenerate Swagger documentation with corrected paths Resolves 17/18 code review findings including security, documentation, and testing improvements. Core RBAC functionality remains intact with enhanced error handling and test coverage. Story: 5.5.2-rbac-api-endpoints Module: auth Files: 12 modified, 1 added, 14 deleted
1 parent 9a72ddf commit 230360f

27 files changed

+1845
-1346
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,5 @@ ssl/
4242
# Locale backup files
4343
*.backup.*
4444
core/locales/*.backup.*
45+
# Ignore locale backup files
46+
core/locales/*.backup.*

core/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,4 @@ temp/
4242

4343
# Docker
4444
docker-compose.override.yml
45+
*.backup.*

core/cmd/server/main.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,23 @@ import (
2626
_ "github.com/lib/pq"
2727
)
2828

29-
// @title AppRun API
30-
// @version 1.0
31-
// @description AppRun Platform REST API Documentation
32-
// @termsOfService http://swagger.io/terms/
29+
// @title AppRun API
30+
// @version 1.0
31+
// @description AppRun Platform REST API Documentation
32+
// @termsOfService http://swagger.io/terms/
3333

34-
// @contact.name API Support
35-
// @contact.email support@websoft9.com
34+
// @contact.name API Support
35+
// @contact.email support@websoft9.com
3636

37-
// @license.name Apache 2.0
38-
// @license.url http://www.apache.org/licenses/LICENSE-2.0.html
37+
// @license.name Apache 2.0
38+
// @license.url http://www.apache.org/licenses/LICENSE-2.0.html
3939

40-
// @securityDefinitions.apikey BearerAuth
41-
// @in header
42-
// @name Authorization
43-
// @description Type "Bearer" followed by a space and JWT token.
40+
// @securityDefinitions.apikey BearerAuth
41+
// @in header
42+
// @name Authorization
43+
// @description Type "Bearer" followed by a space and JWT token.
4444

45-
// @schemes http https
45+
// @schemes http https
4646
func main() {
4747
if err := run(); err != nil {
4848
log.Fatalf("❌ %v", err)

core/docs/docs.go

Lines changed: 364 additions & 364 deletions
Large diffs are not rendered by default.

core/docs/swagger.json

Lines changed: 364 additions & 364 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)