Skip to content

Commit 0035c07

Browse files
committed
Simplify resolveDefaultContext
1 parent 538c849 commit 0035c07

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

webware/URLParser.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def __init__(self, app):
139139

140140
# region Context handling
141141

142-
def resolveDefaultContext(self, name, dest):
142+
def resolveDefaultContext(self, dest):
143143
"""Find default context.
144144
145145
Figure out if the default context refers to an existing context,
@@ -149,19 +149,16 @@ def resolveDefaultContext(self, name, dest):
149149
or 'default' if the default context is unique.
150150
"""
151151
contexts = self._contexts
152-
contextDirs = {}
153-
# make a list of existing context paths
154-
for name, path in contexts.items():
155-
if name != 'default':
156-
contextDirs[self.absContextPath(path)] = name
157152
if dest in contexts:
158153
# The default context refers to another context,
159154
# not a unique context. Return the name of that context.
160155
return dest
161-
if self.absContextPath(dest) in contextDirs:
162-
# The default context has the same directory
163-
# as another context, so it's still not unique
164-
return contextDirs[self.absContextPath(dest)]
156+
destPath = self.absContextPath(dest)
157+
for name, path in contexts.items():
158+
if name != 'default' and self.absContextPath(path) == destPath:
159+
# The default context has the same directory
160+
# as another context, so it's still not unique
161+
return name
165162
# The default context has no other name
166163
return 'default'
167164

@@ -173,7 +170,7 @@ def addContext(self, name, path):
173170
the context name.
174171
"""
175172
if name == 'default':
176-
dest = self.resolveDefaultContext(name, path)
173+
dest = self.resolveDefaultContext(name)
177174
self._defaultContext = dest
178175
if dest != 'default':
179176
# in this case default refers to an existing context, so

0 commit comments

Comments
 (0)