Skip to content
This repository was archived by the owner on May 1, 2021. It is now read-only.

Commit 46519bf

Browse files
committed
[scoreboard] Fix issue with interval cleared for wrong person on player logout
1 parent 11c372b commit 46519bf

File tree

1 file changed

+21
-16
lines changed

1 file changed

+21
-16
lines changed

scripts/info/scoreboard.js

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Currently, the rank will be any rank beginning with "rank", and "level" for the
99
1010
Made by Weissnix4711
1111
12-
v1.2
12+
v1.3
1313
*/
1414

1515
import {
@@ -32,8 +32,6 @@ const system = server.registerSystem(0, 0);
3232

3333
console.log("scoreboard.js loaded")
3434

35-
var interval;
36-
3735
onPlayerInitialized(player => {
3836
try {
3937
//first init
@@ -44,7 +42,11 @@ onPlayerInitialized(player => {
4442
let i = 0;
4543

4644
//update scoreboard every 15
47-
interval = setInterval(() => {
45+
var interval = setInterval(() => {
46+
47+
//debugging only! spams console
48+
//console.log(player.name);
49+
4850
//variables
4951
let money = getBalance(playerData);
5052
let playerCount = getPlayerList().length;
@@ -157,19 +159,22 @@ onPlayerInitialized(player => {
157159
list.set(playerData, 15, "⭕§dMojang's ToS", 15);
158160

159161
i++;
160-
}, 15)
161-
} catch(err) {
162-
console.error(err);
163-
}
164-
})
165162

166-
onPlayerLeft(player => {
167-
try {
168-
//stop interval
169-
clearInterval(interval);
170-
//destroy scoreboard for player
171-
sidebar.deinit(getPlayerByNAME(player.name));
172-
list.deinit(getPlayerByNAME(player.name));
163+
onPlayerLeft(playerLeave => {
164+
try {
165+
if (playerLeave.name === player.name) {
166+
//stop interval
167+
clearInterval(interval);
168+
//destroy scoreboard for player
169+
sidebar.deinit(getPlayerByNAME(playerLeave.name));
170+
list.deinit(getPlayerByNAME(playerLeave.name));
171+
}
172+
} catch(err) {
173+
console.error(err);
174+
}
175+
})
176+
177+
}, 15)
173178
} catch(err) {
174179
console.error(err);
175180
}

0 commit comments

Comments
 (0)