Merge pull request #108 from MasterFelX/hotfix/nested-transform-issue

Fix issue of missing nested DTO properties when transforming DTO

Author: WendellAdriel

src/SimpleDTO.php

@@ -499,7 +499,7 @@ private function transformCollectionToArray(Collection $collection): array
     private function transformDTOToArray(SimpleDTO $dto): array
     {
         $result = [];
-        foreach ($dto->validatedData as $key => $value) {
+        foreach ($dto->buildDataForExport() as $key => $value) {
             $result[$key] = $this->isArrayable($value)
                 ? $this->formatArrayableValue($value)
                 : $value;

tests/Datasets/SimpleInnerDTO.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace WendellAdriel\ValidatedDTO\Tests\Datasets;
+
+use WendellAdriel\ValidatedDTO\Casting\IntegerCast;
+use WendellAdriel\ValidatedDTO\Casting\StringCast;
+use WendellAdriel\ValidatedDTO\SimpleDTO;
+
+class SimpleInnerDTO extends SimpleDTO
+{
+    public string $name;
+
+    public int $number;
+
+    protected function defaults(): array
+    {
+        return [];
+    }
+
+    protected function casts(): array
+    {
+        return [
+            'name' => new StringCast(),
+            'number' => new IntegerCast(),
+        ];
+    }
+}

tests/Datasets/SimpleOuterDTO.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace WendellAdriel\ValidatedDTO\Tests\Datasets;
+
+use WendellAdriel\ValidatedDTO\Casting\DTOCast;
+use WendellAdriel\ValidatedDTO\Casting\IntegerCast;
+use WendellAdriel\ValidatedDTO\Casting\StringCast;
+use WendellAdriel\ValidatedDTO\SimpleDTO;
+
+class SimpleOuterDTO extends SimpleDTO
+{
+    public string $name;
+
+    public SimpleInnerDTO $inner;
+
+    protected function defaults(): array
+    {
+        return [];
+    }
+
+    protected function casts(): array
+    {
+        return [
+            'name' => new StringCast(),
+            'number' => new IntegerCast(),
+            'inner' => new DTOCast(SimpleInnerDTO::class),
+        ];
+    }
+}

tests/Unit/SimpleDTOTest.php

@@ -17,6 +17,7 @@
 use WendellAdriel\ValidatedDTO\Tests\Datasets\SimpleMappedNameDTO;
 use WendellAdriel\ValidatedDTO\Tests\Datasets\SimpleNameDTO;
 use WendellAdriel\ValidatedDTO\Tests\Datasets\SimpleNullableDTO;
+use WendellAdriel\ValidatedDTO\Tests\Datasets\SimpleOuterDTO;
 use WendellAdriel\ValidatedDTO\Tests\Datasets\SimpleUserDTO;
 use WendellAdriel\ValidatedDTO\Tests\Datasets\User;
 
@@ -314,3 +315,40 @@ public function __invoke() {}
     expect($dto->age)->toBe(20)
         ->and($dto->toArray())->toBe(['age' => 20, 'doc' => 'test']);
 });
+
+it('checks that update for nested DTO property reflects while converting DTO to array', function () {
+    $dto = SimpleOuterDTO::fromArray([
+        'name' => 'name',
+        'inner' => [
+            'name' => 'inner name',
+            'number' => 2,
+        ],
+    ]);
+
+    $dto->inner->name = 'updated inner name';
+
+    expect($dto->inner->name)->toBe('updated inner name')
+        ->and($dto->toArray())->toBe([
+            'name' => 'name',
+            'inner' => [
+                'name' => 'updated inner name',
+                'number' => 2,
+            ],
+        ]);
+});
+
+it('checks that update for nested DTO property reflects while converting DTO to json', function () {
+    $array = [
+        'name' => 'name',
+        'inner' => [
+            'name' => 'inner name',
+            'number' => 2,
+        ],
+    ];
+    $dto = SimpleOuterDTO::fromArray($array);
+
+    $dto->inner->name = 'updated inner name';
+
+    expect($dto->inner->name)->toBe('updated inner name')
+        ->and($dto->toJson())->toBe(json_encode(['name' => 'name', 'inner' => ['name' => 'updated inner name', 'number' => 2]]));
+});