impr: Remove unnecessary moves in the task manager

Author: WerWolv

lib/libimhex/source/api/task_manager.cpp

@@ -65,7 +65,7 @@ namespace hex {
 
 
     Task::Task(const UnlocalizedString &unlocalizedName, u64 maxValue, bool background, bool blocking, std::function<void(Task &)> function)
-    : m_unlocalizedName(std::move(unlocalizedName)),
+    : m_unlocalizedName(unlocalizedName),
       m_maxValue(maxValue),
       m_function(std::move(function)),
       m_background(background), m_blocking(blocking) { }
@@ -344,7 +344,7 @@ namespace hex {
         std::scoped_lock lock(s_queueMutex);
 
         // Construct new task
-        auto task = std::make_shared<Task>(std::move(unlocalizedName), maxValue, background, blocking, std::move(function));
+        auto task = std::make_shared<Task>(unlocalizedName, maxValue, background, blocking, std::move(function));
 
         s_tasks.emplace_back(task);
 
@@ -359,12 +359,12 @@ namespace hex {
 
     TaskHolder TaskManager::createTask(const UnlocalizedString &unlocalizedName, u64 maxValue, std::function<void(Task &)> function) {
         log::debug("Creating task {}", unlocalizedName.get());
-        return createTask(std::move(unlocalizedName), maxValue, false, false, std::move(function));
+        return createTask(unlocalizedName, maxValue, false, false, std::move(function));
     }
 
     TaskHolder TaskManager::createTask(const UnlocalizedString &unlocalizedName, u64 maxValue, std::function<void()> function) {
         log::debug("Creating task {}", unlocalizedName.get());
-        return createTask(std::move(unlocalizedName), maxValue, false, false,
+        return createTask(unlocalizedName, maxValue, false, false,
             [function = std::move(function)](Task&) {
                 function();
             }
@@ -373,12 +373,12 @@ namespace hex {
 
     TaskHolder TaskManager::createBackgroundTask(const UnlocalizedString &unlocalizedName, std::function<void(Task &)> function) {
         log::debug("Creating background task {}", unlocalizedName.get());
-        return createTask(std::move(unlocalizedName), 0, true, false, std::move(function));
+        return createTask(unlocalizedName, 0, true, false, std::move(function));
     }
 
     TaskHolder TaskManager::createBackgroundTask(const UnlocalizedString &unlocalizedName, std::function<void()> function) {
         log::debug("Creating background task {}", unlocalizedName.get());
-        return createTask(std::move(unlocalizedName), 0, true, false,
+        return createTask(unlocalizedName, 0, true, false,
             [function = std::move(function)](Task&) {
                 function();
             }
@@ -387,12 +387,12 @@ namespace hex {
 
     TaskHolder TaskManager::createBlockingTask(const UnlocalizedString &unlocalizedName, u64 maxValue, std::function<void(Task &)> function) {
         log::debug("Creating blocking task {}", unlocalizedName.get());
-        return createTask(std::move(unlocalizedName), maxValue, true, true, std::move(function));
+        return createTask(unlocalizedName, maxValue, true, true, std::move(function));
     }
 
     TaskHolder TaskManager::createBlockingTask(const UnlocalizedString &unlocalizedName, u64 maxValue, std::function<void()> function) {
         log::debug("Creating blocking task {}", unlocalizedName.get());
-        return createTask(std::move(unlocalizedName), maxValue, true, true,
+        return createTask(unlocalizedName, maxValue, true, true,
             [function = std::move(function)](Task&) {
                 function();
             }