Overwriting a hexpat that hasn't been modified crashes Nigthly

[NaitorStudios]

Title resumes it well, but I'm here in case this only happens on my side so we can investigate!

[paxcut]

I opened a hexpat from the file menu>open pattern. When it is loaded I pressed File>save pattern. I was notified the pattern had changed and if i wanted to reload it, i said yes and no crash happened. Can you post the actual steps to reproduce?

[NaitorStudios]

I'm not sure what happens exactly, but I'm editing the hexpat both inside ImHex and sometimes outside of it.
Sometimes I think I haven't saved, and that maybe the pattern didn't reported the changes, so I proceed to Save Pattern As...
Select the same pattern that was automatically loaded by my file, and it crashes.

[paxcut]

Ok, Now I can reproduce it. When you load a pattern, ImHex keeps track of the changes that may occur to the file using a file tracker. That means that if the Save Pattern is greyed out, then the file on disk and on the pattern editor are identical. If you want to track a different file then you can use Save Pattern AS, but you must choose a different file.The bug you found happens because the file tracker is expecting a different and it is assuming it is different. It tries to change the file being tracked to the same exact file it was already tracking and that makes it crash. I need to check if the file is the same so that it doesn't try to change the tracker.

[paxcut]

The problem was that it is not possible to have two trackers tracking the same file. So I check it the files are the same and if they are I stop tracking the original and creating a new tracker works without crash. Thanks for finding this! It should be fixed in the next nightly and the next release.