eqwalize some tests (144)

Summary: enroll, fix typing issues

Differential Revision: D85583805

fbshipit-source-id: 7088ad541ef494a957bda2526f0554aa6aaf6023

Author: ilya-klyuchnikov

taint_server/src/taint_message_passer.erl

@@ -39,7 +39,7 @@ uninit() ->
 blocking_get(MessageId) ->
     blocking_get(MessageId, 12000).
 
--spec blocking_get(string(), number()) -> taint_abstract_machine:taint_value().
+-spec blocking_get(string(), erlang:timeout()) -> taint_abstract_machine:taint_value().
 blocking_get(MessageId, Timeout) ->
     case ets:insert_new(taint_messages, {MessageId, nomsg, self()}) of
         false ->

taint_server/test/message_passer_SUITE.erl

@@ -19,6 +19,7 @@
 %%% @end
 %%% -------------------------------------------------------------------
 -module(message_passer_SUITE).
+-typing([eqwalizer]).
 
 -include_lib("stdlib/include/assert.hrl").
 
@@ -64,9 +65,9 @@ init_per_testcase(_TestCase, Config) ->
     taint_message_passer:init(),
     Config.
 
-end_per_testcase(_TestCase, Config) ->
+end_per_testcase(_TestCase, _Config) ->
     taint_message_passer:uninit(),
-    Config.
+    ok.
 
 init_per_suite(Config) ->
     Config.
@@ -78,11 +79,13 @@ end_per_suite(_Config) ->
 %% TEST CASES
 
 first_set_then_get(_Config) ->
+    Msg1 = {taint, [{step, "msg1"}]},
     MsgId = ref_to_list(make_ref()),
-    taint_message_passer:set(MsgId, msg1),
-    ?assertEqual(msg1, taint_message_passer:blocking_get(MsgId)).
+    taint_message_passer:set(MsgId, Msg1),
+    ?assertEqual(Msg1, taint_message_passer:blocking_get(MsgId)).
 
 first_get_then_set(_Config) ->
+    Msg2 = {taint, [{step, "msg2"}]},
     MsgId = ref_to_list(make_ref()),
     ReplyTo = self(),
     spawn_link(fun() ->
@@ -93,13 +96,13 @@ first_get_then_set(_Config) ->
     receive
         started -> ok
     end,
-    taint_message_passer:set(MsgId, msg2),
+    taint_message_passer:set(MsgId, Msg2),
     Message =
         receive
             {got_msg, Msg} -> Msg
         after 5000 -> timeout
         end,
-    ?assertEqual(msg2, Message).
+    ?assertEqual(Msg2, Message).
 
 message_after_timeout(_Config) ->
     MsgId = ref_to_list(make_ref()),
@@ -119,15 +122,17 @@ message_after_timeout(_Config) ->
     end,
 
     % This message timed-out so we shouldn't receive it
-    taint_message_passer:set(MsgId, msg),
+    Msg = {taint, [{step, "msg"}]},
+    taint_message_passer:set(MsgId, Msg),
     % This is the message we want
-    taint_message_passer:set(MsgId1, msg2),
+    Msg2 = {taint, [{step, "msg2"}]},
+    taint_message_passer:set(MsgId1, Msg2),
     Message =
         receive
             {got_msg, RecMsg} -> RecMsg
         after 4000 -> timeout
         end,
-    ?assertEqual(msg2, Message).
+    ?assertEqual(Msg2, Message).
 
 % Getting the same message twice shouldn't
 % happen so we expect to crash if it does
@@ -143,7 +148,8 @@ get_twice_and_crash(_Config) ->
     receive
         started -> ok
     end,
-    taint_message_passer:set(MsgId, msg2),
+    Msg2 = {taint, [{step, "msg2"}]},
+    taint_message_passer:set(MsgId, Msg2),
     receive
         ok -> ok
     end.