Remove direct manipulation of storage state

Summary:
Remove an export that uses `sys:replace_state/2` to directly manipulate storage
state since `make_empty_snapshot` and `open_snapshot` can now achieve the
same result.

Reviewed By: jaher

Differential Revision: D72437281

fbshipit-source-id: 499548a08ebaa9b29dd9fe68b2c34841b3c1993f

Author: hsun324

src/wa_raft_storage.erl

@@ -69,13 +69,6 @@
     code_change/3
 ]).
 
-%% Test API
--ifdef(TEST).
--export([
-    reset/3
-]).
--endif.
-
 -export_type([
     storage_handle/0,
     metadata/0,
@@ -396,17 +389,6 @@ label(ServiceRef) ->
 config(ServiceRef) ->
     gen_server:call(ServiceRef, config, ?RAFT_STORAGE_CALL_TIMEOUT()).
 
--ifdef(TEST).
--spec reset(ServiceRef :: pid() | atom(), Position :: wa_raft_log:log_pos(), Config :: wa_raft_server:config() | undefined) -> ok | error().
-reset(ServiceRef, Position, Config) ->
-    sys:replace_state(ServiceRef, fun (#state{module = Module, handle = Handle} = State) ->
-        Config =/= undefined andalso
-            Module:storage_apply_config(Config, Position, Handle),
-        State#state{last_applied = Position}
-    end, ?RAFT_STORAGE_CALL_TIMEOUT()),
-    ok.
--endif.
-
 %%-------------------------------------------------------------------
 %% RAFT Storage - Internal API
 %%-------------------------------------------------------------------