Skip to content

Commit 9279c20

Browse files
committed
fix: remove hardcoded string values in task view
1 parent 75b8d5c commit 9279c20

File tree

2 files changed

+8
-18
lines changed

2 files changed

+8
-18
lines changed

app/src/main/res/layout/activity_task_view.xml

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
android:layout_weight="1"
4343
android:ems="10"
4444
android:gravity="start"
45-
android:text="Task Date Placeholder"
45+
android:text="@string/task_date_placeholder"
4646
android:textAlignment="center"
4747
android:textAppearance="@style/TextAppearance.AppCompat.Large" />
4848

@@ -53,34 +53,21 @@
5353
android:layout_weight="1"
5454
android:ems="10"
5555
android:gravity="start"
56-
android:text="Task Time Placeholder"
56+
android:text="@string/task_time_placeholder"
5757
android:textAlignment="center"
5858
android:textAppearance="@style/TextAppearance.AppCompat.Large" />
5959
</LinearLayout>
6060

61-
<Button
62-
android:id="@+id/btn_save_task"
63-
android:layout_width="0dp"
64-
android:layout_height="wrap_content"
65-
android:layout_marginBottom="8dp"
66-
android:layout_marginEnd="8dp"
67-
android:layout_marginStart="8dp"
68-
android:text="@string/save_task_label"
69-
android:textAlignment="center"
70-
app:layout_constraintBottom_toBottomOf="parent"
71-
app:layout_constraintEnd_toEndOf="parent"
72-
app:layout_constraintHorizontal_bias="0.498"
73-
app:layout_constraintStart_toStartOf="parent" />
74-
7561
<CheckBox
7662
android:id="@+id/useCurrentTime"
7763
android:layout_width="wrap_content"
7864
android:layout_height="wrap_content"
7965
android:layout_marginStart="8dp"
8066
android:layout_marginTop="8dp"
8167
android:checked="true"
82-
android:text="Use Current Time"
68+
android:text="@string/use_current_time"
8369
app:layout_constraintStart_toStartOf="parent"
84-
app:layout_constraintTop_toBottomOf="@+id/linearLayout" />
70+
app:layout_constraintTop_toBottomOf="@+id/linearLayout"
71+
android:layout_marginLeft="8dp" />
8572

8673
</android.support.constraint.ConstraintLayout>

app/src/main/res/values/strings.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,7 @@
7474
<string name="task_name_label">Task Name</string>
7575
<string name="task_time">Task Time</string>
7676
<string name="save_task_label">Save Task</string>
77+
<string name="task_date_placeholder">00/00/0000</string>
78+
<string name="task_time_placeholder">00:00:00</string>
79+
<string name="use_current_time">Use current time</string>
7780
</resources>

0 commit comments

Comments
 (0)