feat: better GitHub links, attempt to force activity chooser for opening links

Author: AKPWebDesign

app/build.gradle

@@ -41,6 +41,9 @@ android {
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true
     }
+    applicationVariants.all { variant ->
+        variant.resValue "string", "versionName", variant.versionName
+    }
     buildTypes {
         release {
             minifyEnabled false

app/src/main/java/tech/akpmakes/android/taskkeeper/SettingsActivity.java

@@ -107,39 +107,36 @@ public boolean onPreferenceClick(Preference preference) {
             findPreference("social_discord").setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
                 @Override
                 public boolean onPreferenceClick(Preference preference) {
-                    Intent i = new Intent(Intent.ACTION_VIEW);
-                    i.setData(Uri.parse(getString(R.string.social_discord_uri)));
-                    startActivity(i);
+                    Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(getString(R.string.social_discord_uri)));
+                    startActivity(Intent.createChooser(i, null));
                     return true;
                 }
             });
 
             findPreference("social_github").setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
                 @Override
                 public boolean onPreferenceClick(Preference preference) {
-                    Intent i = new Intent(Intent.ACTION_VIEW);
-                    i.setData(Uri.parse(getString(R.string.social_github_uri)));
-                    startActivity(i);
+                    Intent i = new Intent(Intent.ACTION_VIEW,
+                            Uri.parse(getString(R.string.social_github_uri, getString(R.string.versionName))));
+                    startActivity(Intent.createChooser(i, null));
                     return true;
                 }
             });
 
 			findPreference("privacy_policy").setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
                 @Override
                 public boolean onPreferenceClick(Preference preference) {
-                    Intent i = new Intent(Intent.ACTION_VIEW);
-                    i.setData(Uri.parse(getString(R.string.privacy_policy_uri)));
-                    startActivity(i);
+                    Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(getString(R.string.privacy_policy_uri)));
+                    startActivity(Intent.createChooser(i, null));
                     return true;
                 }
             });
 
             findPreference("more_info").setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
                 @Override
                 public boolean onPreferenceClick(Preference preference) {
-                    Intent i = new Intent(Intent.ACTION_VIEW);
-                    i.setData(Uri.parse(getString(R.string.more_information_uri)));
-                    startActivity(i);
+                    Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(getString(R.string.more_information_uri)));
+                    startActivity(Intent.createChooser(i, null));
                     return true;
                 }
             });

app/src/main/res/values/strings.xml

@@ -65,7 +65,7 @@
     <string name="social_discord_uri">https://discord.gg/9GpztdT</string>
     <string name="social_github_title">GitHub</string>
     <string name="social_github_summary">When is Open Source! Check out the code on GitHub!</string>
-    <string name="social_github_uri">https://github.com/WhenApp/WhenApp-Android</string>
+    <string name="social_github_uri">https://github.com/WhenApp/WhenApp-Android/tree/%1$s</string>
     <string name="welcome_screen_title">Welcome screen</string>
     <string name="rate_title">Rate When</string>
     <string name="rate_summary"></string>