Merge pull request marmelab#10371 from marmelab/Fix-set-state-warning

slax57 · web-flow · commit 29f4cab1741d · 2024-11-21T17:36:27.000+01:00
Fix ReferenceManyField executes filter reset filter too often
diff --git a/packages/ra-core/src/controller/field/useReferenceManyFieldController.ts b/packages/ra-core/src/controller/field/useReferenceManyFieldController.ts
@@ -154,7 +154,7 @@ export const useReferenceManyFieldController = <
             filterRef.current = filter;
             setFilterValues(filter);
         }
-    });
+    }, [filter]);
 
     const {
         data,
diff --git a/packages/ra-core/src/controller/list/useList.ts b/packages/ra-core/src/controller/list/useList.ts
@@ -168,7 +168,7 @@ export const useList = <RecordType extends RaRecord = any>(
             filterRef.current = filter;
             setFilterValues(filter);
         }
-    });
+    }, [filter]);
 
     // We do all the data processing (filtering, sorting, paginating) client-side
     useEffect(

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ export const useReferenceManyFieldController = <`
`154`	`154`	`filterRef.current = filter;`
`155`	`155`	`setFilterValues(filter);`
`156`	`156`	`}`
`157`		`- });`
	`157`	`+ }, [filter]);`
`158`	`158`
`159`	`159`	`const {`
`160`	`160`	`data,`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ export const useList = <RecordType extends RaRecord = any>(`
`168`	`168`	`filterRef.current = filter;`
`169`	`169`	`setFilterValues(filter);`
`170`	`170`	`}`
`171`		`- });`
	`171`	`+ }, [filter]);`
`172`	`172`
`173`	`173`	`// We do all the data processing (filtering, sorting, paginating) client-side`
`174`	`174`	`useEffect(`