Merge remote-tracking branch 'origin/master' into crm-can-access

slax57 · slax57 · commit 5ae249cd557a · 2024-10-28T15:28:18.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,16 @@
 # Changelog
 
+## 5.3.1
+
+* Fix smart count for no results message ([#10295](https://github.com/marmelab/react-admin/pull/10295)) ([thibault-barrat](https://github.com/thibault-barrat))
+* Fix double decoding of ids in URLs ([#10293](https://github.com/marmelab/react-admin/pull/10293)) ([djhi](https://github.com/djhi))
+* Fix no results message has untranslated resource name ([#10291](https://github.com/marmelab/react-admin/pull/10291)) ([fzaninotto](https://github.com/fzaninotto))
+* Fix `<AutocompleteInput>` displays 'Create' option for choices that already exist when `createLabel` is provided ([#10288](https://github.com/marmelab/react-admin/pull/10288)) ([slax57](https://github.com/slax57))
+* [Doc] Fix Authorization link in Authentication page ([#10303](https://github.com/marmelab/react-admin/pull/10303)) ([djhi](https://github.com/djhi))
+* [Doc] Remove outdated warning about `<SimpleFormIterator>` cloning its children ([#10302](https://github.com/marmelab/react-admin/pull/10302)) ([slax57](https://github.com/slax57))
+* [Doc] fix example in README ([#10298](https://github.com/marmelab/react-admin/pull/10298)) ([antoinefricker](https://github.com/antoinefricker))
+* [Doc] Document react-hook-form limitation preventing using dynamically added inputs in `<ArrayInput>` with `shouldUnregister` ([#10271](https://github.com/marmelab/react-admin/pull/10271)) ([djhi](https://github.com/djhi))
+
 ## 5.3.0
 
 * Make authentication check pessimistic
@@ -262,6 +273,15 @@ We estimate that a react-admin app with 50,000 lines of code will require about
 
 ### Changelog
 
+* [Doc] Fix Authorization link in Authentication page ([#10303](https://github.com/marmelab/react-admin/pull/10303)) ([djhi](https://github.com/djhi))
+* [Doc] Remove outdated warning about `<SimpleFormIterator>` cloning its children ([#10302](https://github.com/marmelab/react-admin/pull/10302)) ([slax57](https://github.com/slax57))
+* [Doc] fix example in README ([#10298](https://github.com/marmelab/react-admin/pull/10298)) ([antoinefricker](https://github.com/antoinefricker))
+* Fix smart count for no results message ([#10295](https://github.com/marmelab/react-admin/pull/10295)) ([thibault-barrat](https://github.com/thibault-barrat))
+* Fix double decoding of ids in URLs ([#10293](https://github.com/marmelab/react-admin/pull/10293)) ([djhi](https://github.com/djhi))
+* Fix no results message has untranslated resource name ([#10291](https://github.com/marmelab/react-admin/pull/10291)) ([fzaninotto](https://github.com/fzaninotto))
+* Fix `<AutocompleteInput>` displays 'Create' option for choices that already exist when `createLabel` is provided ([#10288](https://github.com/marmelab/react-admin/pull/10288)) ([slax57](https://github.com/slax57))
+* [Doc] Document react-hook-form limitation preventing using dynamically added inputs in `<ArrayInput>` with `shouldUnregister` ([#10271](https://github.com/marmelab/react-admin/pull/10271)) ([djhi](https://github.com/djhi))
+
 * [Doc] Update `<StackedFilters>` doc for `ra-form-layout` v5.2.0 ([#10268](https://github.com/marmelab/react-admin/pull/10268)) ([erwanMarmelab](https://github.com/erwanMarmelab))
 * Fix `<AutoCompleteInput>` should not display a "Create" option when the filter is empty ([#10266](https://github.com/marmelab/react-admin/pull/10266)) ([erwanMarmelab](https://github.com/erwanMarmelab))
 * Fix pnpm error Module not found: Can't resolve '@mui/utils' ([#10264](https://github.com/marmelab/react-admin/pull/10264)) ([slax57](https://github.com/slax57))
diff --git a/docs/ArrayInput.md b/docs/ArrayInput.md
@@ -79,6 +79,8 @@ Check [the `<SimpleFormIterator>` documentation](./SimpleFormIterator.md) for de
 
 **Tip**: If you need to edit an array of *related* records, i.e. if the `items` above actually come from another resource, you should use a [`<ReferenceManyInput>`](./ReferenceManyInput.md) instead.
 
+**Note**: Using [`shouldUnregister`](https://react-hook-form.com/docs/useform#shouldUnregister) should be avoided when using `<ArrayInput>` (which internally uses `useFieldArray`) as the unregister function gets called after input unmount/remount and reorder. This limitation is mentioned in the react-hook-form [documentation](https://react-hook-form.com/docs/usecontroller#props). If you are in such a situation, you can use the [`transform`](https://marmelab.com/react-admin/Edit.html#transform) prop to manually clean the submitted values.
+
 ## Props
 
 `<ArrayInput>` accepts the [common input props](./Inputs.md#common-input-props) (except `format` and `parse`).
diff --git a/docs/Authentication.md b/docs/Authentication.md
@@ -416,7 +416,7 @@ export const dataProvider = addRefreshAuthToDataProvider(baseDataProvider, refre
 
 ## Authorization
 
-Access control and permissions allow you to restrict certain pages to specific users. React-admin provides powerful primitives for implementing authorization logic. For detailed guidance, check out the [Authorization](./Authorization.md) documentation.
+Access control and permissions allow you to restrict certain pages to specific users. React-admin provides powerful primitives for implementing authorization logic. For detailed guidance, check out the [Authorization](./Permissions.md) documentation.
 
 <video controls autoplay muted loop>
   <source src="./img/AccessControl.mp4" type="video/mp4"/>
diff --git a/docs/Forms.md b/docs/Forms.md
@@ -363,6 +363,8 @@ import { FormDataConsumer } from 'react-admin';
 
 **Note**: By default, `react-hook-form` submits values of unmounted input components. In the above example, the `shouldUnregister` prop of the `<SimpleForm>` component prevents that from happening. That way, when end users hide an input, its value isn't included in the submitted data.
 
+**Note**: `shouldUnregister` should be avoided when using `<ArrayInput>` (which internally uses `useFieldArray`) as the unregister function gets called after input unmount/remount and reorder. This limitation is mentioned in the react-hook-form [documentation](https://react-hook-form.com/docs/usecontroller#props). If you are in such a situation, you can use the [`transform`](https://marmelab.com/react-admin/Edit.html#transform) prop to manually clean the submitted values.
+
 ## Transforming Form Values Before Submitting
 
 Sometimes, you may want to alter the form values before sending them to the `dataProvider`. For those cases, use the `transform` prop either on the view component (`<Create>` or `<Edit>`) or on the `<SaveButton>` component. 
diff --git a/docs/Inputs.md b/docs/Inputs.md
@@ -707,6 +707,8 @@ import { FormDataConsumer } from 'react-admin';
 
 **Note**: By default, `react-hook-form` submits values of unmounted input components. In the above example, the `shouldUnregister` prop of the `<SimpleForm>` component prevents that from happening. That way, when end users hide an input, its value isn't included in the submitted data.
 
+**Note**: `shouldUnregister` should be avoided when using `<ArrayInput>` (which internally uses `useFieldArray`) as the unregister function gets called after input unmount/remount and reorder. This limitation is mentioned in the react-hook-form [documentation](https://react-hook-form.com/docs/usecontroller#props). If you are in such a situation, you can use the [`transform`](https://marmelab.com/react-admin/Edit.html#transform) prop to manually clean the submitted values.
+
 ## Overriding The Input Variant
 
 Material UI offers [3 variants for text fields](https://mui.com/material-ui/react-text-field/#basic-textfield): `outlined`, `filled`, and `standard`. The default react-admin theme uses the `filled` variant.
diff --git a/docs/SimpleFormIterator.md b/docs/SimpleFormIterator.md
@@ -185,8 +185,6 @@ import { ArrayInput, SimpleFormIterator, DateInput, TextField, FormDataConsumer,
 </ArrayInput>
 ```
 
-**Caution**: `<SimpleFormIterator>` **clones** its children several times, as it needs to override their actual source for each record. If you use a custom Input element, make sure they accept a custom `source` prop. 
-
 ## `className`
 
 CSS classes passed to the root component. 
diff --git a/docs/TabbedForm.md b/docs/TabbedForm.md
@@ -510,7 +510,7 @@ export const TagEdit = () => (
 
 - `label`: the label of the tab
 - `path`: the path of the tab in the URL (ignored when `syncWithLocation={false}`)
-- `count`: the number of items in the tab (dislayed close to the label)
+- `count`: the number of items in the tab (displayed close to the label)
 - `sx`: custom styles to apply to the tab
 - `children`: the content of the tab (usually a list of inputs)
 
diff --git a/docs/TabbedShowLayout.md b/docs/TabbedShowLayout.md
@@ -86,7 +86,7 @@ It accepts the following props:
 - `label`: The string displayed for each tab
 - `icon`: The icon to show before the label (optional). Must be a component.
 - `path`: The string used for custom urls (optional)
-- `count`: the number of items in the tab (dislayed close to the label)
+- `count`: the number of items in the tab (displayed close to the label)
 
 ```jsx
 // in src/posts.js
diff --git a/examples/data-generator/package.json b/examples/data-generator/package.json
@@ -1,6 +1,6 @@
 {
     "name": "data-generator-retail",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "homepage": "https://github.com/marmelab/react-admin/tree/master/examples/data-generator",
     "bugs": "https://github.com/marmelab/react-admin/issues",
     "license": "MIT",
@@ -19,7 +19,7 @@
     },
     "devDependencies": {
         "cross-env": "^5.2.0",
-        "ra-core": "^5.3.0",
+        "ra-core": "^5.3.1",
         "rimraf": "^3.0.2",
         "typescript": "^5.1.3"
     },
diff --git a/examples/simple/package.json b/examples/simple/package.json
@@ -1,6 +1,6 @@
 {
     "name": "simple",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "private": true,
     "type": "module",
     "scripts": {
@@ -18,13 +18,13 @@
         "@tanstack/react-query-devtools": "^5.8.4",
         "jsonexport": "^3.2.0",
         "lodash": "~4.17.5",
-        "ra-data-fakerest": "^5.3.0",
-        "ra-i18n-polyglot": "^5.3.0",
-        "ra-input-rich-text": "^5.3.0",
-        "ra-language-english": "^5.3.0",
-        "ra-language-french": "^5.3.0",
+        "ra-data-fakerest": "^5.3.1",
+        "ra-i18n-polyglot": "^5.3.1",
+        "ra-input-rich-text": "^5.3.1",
+        "ra-language-english": "^5.3.1",
+        "ra-language-french": "^5.3.1",
         "react": "^18.3.1",
-        "react-admin": "^5.3.0",
+        "react-admin": "^5.3.1",
         "react-dom": "^18.3.1",
         "react-hook-form": "^7.53.0",
         "react-router": "^6.22.0",
diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
     "lerna": "2.5.1",
     "packages": ["examples/data-generator", "examples/simple", "packages/*"],
-    "version": "5.3.0"
+    "version": "5.3.1"
 }
diff --git a/packages/create-react-admin/package.json b/packages/create-react-admin/package.json
@@ -1,7 +1,7 @@
 {
     "name": "create-react-admin",
     "description": "A CLI to quickly start a new react-admin project",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "license": "MIT",
     "bin": "lib/cli.js",
     "type": "module",
diff --git a/packages/ra-core/package.json b/packages/ra-core/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-core",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "Core components of react-admin, a frontend Framework for building admin applications on top of REST services, using ES6, React",
     "files": [
         "*.md",
diff --git a/packages/ra-core/src/form/getSimpleValidationResolver.ts b/packages/ra-core/src/form/getSimpleValidationResolver.ts
@@ -101,7 +101,7 @@ const isRaTranslationObj = (obj: object) =>
     Object.keys(obj).includes('message') && Object.keys(obj).includes('args');
 
 const isEmptyObject = (obj: object) =>
-    Object.getOwnPropertyNames(obj).length === 0;
+    obj == null || Object.getOwnPropertyNames(obj).length === 0;
 
 export type ValidateForm = (
     data: FieldValues
diff --git a/packages/ra-data-fakerest/package.json b/packages/ra-data-fakerest/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-data-fakerest",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "JSON Server data provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -43,7 +43,7 @@
         "@types/jest": "^29.5.2",
         "cross-env": "^5.2.0",
         "expect": "^27.4.6",
-        "ra-core": "^5.3.0",
+        "ra-core": "^5.3.1",
         "rimraf": "^3.0.2",
         "typescript": "^5.1.3"
     },
diff --git a/packages/ra-data-graphql-simple/package.json b/packages/ra-data-graphql-simple/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-data-graphql-simple",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "A GraphQL simple data provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -37,7 +37,7 @@
         "graphql-ast-types-browser": "~1.0.2",
         "lodash": "~4.17.5",
         "pluralize": "~7.0.0",
-        "ra-data-graphql": "^5.3.0"
+        "ra-data-graphql": "^5.3.1"
     },
     "peerDependencies": {
         "graphql": "^15.6.0",
diff --git a/packages/ra-data-graphql/package.json b/packages/ra-data-graphql/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-data-graphql",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "A GraphQL data provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
diff --git a/packages/ra-data-json-server/package.json b/packages/ra-data-json-server/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-data-json-server",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "JSON Server data provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -26,7 +26,7 @@
     },
     "dependencies": {
         "query-string": "^7.1.3",
-        "ra-core": "^5.3.0"
+        "ra-core": "^5.3.1"
     },
     "devDependencies": {
         "cross-env": "^5.2.0",
diff --git a/packages/ra-data-localforage/package.json b/packages/ra-data-localforage/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-data-local-forage",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "LocalForage data provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -42,7 +42,7 @@
     "dependencies": {
         "localforage": "^1.7.1",
         "lodash": "~4.17.5",
-        "ra-data-fakerest": "^5.3.0"
+        "ra-data-fakerest": "^5.3.1"
     },
     "devDependencies": {
         "cross-env": "^5.2.0",
diff --git a/packages/ra-data-localstorage/package.json b/packages/ra-data-localstorage/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-data-local-storage",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "Local storage data provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -38,7 +38,7 @@
     },
     "dependencies": {
         "lodash": "~4.17.5",
-        "ra-data-fakerest": "^5.3.0"
+        "ra-data-fakerest": "^5.3.1"
     },
     "devDependencies": {
         "cross-env": "^5.2.0",
diff --git a/packages/ra-data-simple-rest/package.json b/packages/ra-data-simple-rest/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-data-simple-rest",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "Simple REST data provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -29,7 +29,7 @@
     },
     "devDependencies": {
         "cross-env": "^5.2.0",
-        "ra-core": "^5.3.0",
+        "ra-core": "^5.3.1",
         "rimraf": "^3.0.2",
         "typescript": "^5.1.3"
     },
diff --git a/packages/ra-i18n-i18next/package.json b/packages/ra-i18n-i18next/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-i18n-i18next",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "i18next i18n provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -26,7 +26,7 @@
     },
     "dependencies": {
         "i18next": "^23.5.1",
-        "ra-core": "^5.3.0",
+        "ra-core": "^5.3.1",
         "react-i18next": "^14.1.1"
     },
     "devDependencies": {
diff --git a/packages/ra-i18n-polyglot/package.json b/packages/ra-i18n-polyglot/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-i18n-polyglot",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "Polyglot i18n provider for react-admin",
     "main": "dist/cjs/index.js",
     "module": "dist/esm/index.js",
@@ -26,7 +26,7 @@
     },
     "dependencies": {
         "node-polyglot": "^2.2.2",
-        "ra-core": "^5.3.0"
+        "ra-core": "^5.3.1"
     },
     "devDependencies": {
         "cross-env": "^5.2.0",
diff --git a/packages/ra-input-rich-text/package.json b/packages/ra-input-rich-text/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-input-rich-text",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "<RichTextInput> component for react-admin, useful for editing HTML code in admin GUIs.",
     "author": "Gildas Garcia",
     "repository": "marmelab/react-admin",
@@ -51,10 +51,10 @@
         "@testing-library/react": "^15.0.7",
         "@tiptap/extension-mention": "^2.0.3",
         "@tiptap/suggestion": "^2.0.3",
-        "data-generator-retail": "^5.3.0",
-        "ra-core": "^5.3.0",
-        "ra-data-fakerest": "^5.3.0",
-        "ra-ui-materialui": "^5.3.0",
+        "data-generator-retail": "^5.3.1",
+        "ra-core": "^5.3.1",
+        "ra-data-fakerest": "^5.3.1",
+        "ra-ui-materialui": "^5.3.1",
         "react": "^18.3.1",
         "react-dom": "^18.3.1",
         "react-hook-form": "^7.53.0",
diff --git a/packages/ra-language-english/package.json b/packages/ra-language-english/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-language-english",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "English messages for react-admin, the frontend framework for building admin applications on top of REST/GraphQL services",
     "repository": {
         "type": "git",
@@ -21,7 +21,7 @@
         "watch": "tsc --outDir dist/esm --module es2015 --watch"
     },
     "dependencies": {
-        "ra-core": "^5.3.0"
+        "ra-core": "^5.3.1"
     },
     "devDependencies": {
         "rimraf": "^3.0.2",
diff --git a/packages/ra-language-french/package.json b/packages/ra-language-french/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-language-french",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "French messages for react-admin, the frontend framework for building admin applications on top of REST/GraphQL services",
     "repository": {
         "type": "git",
@@ -21,7 +21,7 @@
         "watch": "tsc --outDir dist/esm --module es2015 --watch"
     },
     "dependencies": {
-        "ra-core": "^5.3.0"
+        "ra-core": "^5.3.1"
     },
     "devDependencies": {
         "rimraf": "^3.0.2",
diff --git a/packages/ra-no-code/package.json b/packages/ra-no-code/package.json
@@ -1,6 +1,6 @@
 {
     "name": "ra-no-code",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "description": "",
     "files": [
         "*.md",
@@ -48,8 +48,8 @@
         "inflection": "^3.0.0",
         "lodash": "~4.17.5",
         "papaparse": "^5.3.0",
-        "ra-data-local-storage": "^5.3.0",
-        "react-admin": "^5.3.0",
+        "ra-data-local-storage": "^5.3.1",
+        "react-admin": "^5.3.1",
         "react-dropzone": "^14.2.3"
     },
     "gitHead": "587df4c27bfcec4a756df4f95e5fc14728dfc0d7"
diff --git a/packages/ra-ui-materialui/package.json b/packages/ra-ui-materialui/package.json
diff --git a/packages/ra-ui-materialui/src/input/DateInput.spec.tsx b/packages/ra-ui-materialui/src/input/DateInput.spec.tsx
diff --git a/packages/ra-ui-materialui/src/input/DateInput.stories.tsx b/packages/ra-ui-materialui/src/input/DateInput.stories.tsx
diff --git a/packages/ra-ui-materialui/src/input/DateInput.tsx b/packages/ra-ui-materialui/src/input/DateInput.tsx
diff --git a/packages/react-admin/package.json b/packages/react-admin/package.json
diff --git a/yarn.lock b/yarn.lock
