Skip to content

Commit 0151597

Browse files
authored
Require MW 1.39+, add testing for MW 1.43, make pass (#8)
Remove missing ResourceLoader module, the contents were removed in ef7dec2 but the registration was left behind. MN-142
1 parent 596e518 commit 0151597

File tree

3 files changed

+15
-21
lines changed

3 files changed

+15
-21
lines changed

.github/workflows/ci.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Setup PHP
1919
uses: shivammathur/setup-php@v2
2020
with:
21-
php-version: '8.1'
21+
php-version: '8.3'
2222
extensions: mbstring, intl
2323
coverage: none
2424
tools: composer, phpcs, phplint
@@ -37,8 +37,14 @@ jobs:
3737
strategy:
3838
fail-fast: false
3939
matrix:
40-
php: [ '8.1' ]
41-
mediawiki: [ REL1_39, REL1_41, master ]
40+
php: [ '8.1', '8.3' ]
41+
mediawiki: [ REL1_39, REL1_43 ]
42+
exclude:
43+
# MW 1.39 requires mediawiki/mediawiki-phan-config@0.12.1 which
44+
# requires mediawiki/phan-taint-check-plugin@4.0.0 which crashes
45+
# on PHP 8.2+ due to use of deprecated string interpolation
46+
- php: '8.3'
47+
mediawiki: REL1_39
4248
steps:
4349
- name: Setup PHP
4450
uses: shivammathur/setup-php@v2
@@ -62,7 +68,7 @@ jobs:
6268
composer update
6369
composer update
6470
- name: Phan
65-
run: ./vendor/bin/phan -d extensions/${{ env.EXTNAME }} --minimum-target-php-version=7.4 --long-progress-bar
71+
run: ./vendor/bin/phan -d extensions/${{ env.EXTNAME }} --minimum-target-php-version=8.1 --long-progress-bar
6672

6773
test:
6874
name: PHPUnit
@@ -72,8 +78,8 @@ jobs:
7278
strategy:
7379
fail-fast: false
7480
matrix:
75-
php: ["8.1"]
76-
mediawiki: [REL1_39]
81+
php: [ '8.1', '8.3' ]
82+
mediawiki: [ REL1_39, REL1_43 ]
7783
steps:
7884
- name: Setup Extension
7985
uses: actions/checkout@v3

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"require-dev": {
3-
"mediawiki/mediawiki-codesniffer": "38.0.0 || 42.0.0 || 43.0.0",
3+
"mediawiki/mediawiki-codesniffer": "48.0.0 || 45.0.0 || 38.0.0",
44
"mediawiki/mediawiki-phan-config": "0.12.1 || 0.14.0",
55
"mediawiki/minus-x": "1.1.3",
66
"php-parallel-lint/php-console-highlighter": "0.5 || 1.0.0",
7-
"php-parallel-lint/php-parallel-lint": "1.3.1 || 1.3.2 || 1.4.0"
7+
"php-parallel-lint/php-parallel-lint": "1.3.1 || 1.4.0"
88
},
99
"scripts": {
1010
"test": [

extension.json

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"license-name": "GPL-2.0-or-later",
99
"type": "other",
1010
"requires": {
11-
"MediaWiki": ">= 1.35.0"
11+
"MediaWiki": ">= 1.39.0"
1212
},
1313
"AutoloadNamespaces": {
1414
"MediaWiki\\Extension\\SummaryToJiraComment\\": "src/"
@@ -37,17 +37,5 @@
3737
"i18n"
3838
]
3939
},
40-
"ResourceModules": {
41-
"ext.summaryToJiraComment": {
42-
"localBasePath": "resources/ext.summaryToJiraComment",
43-
"remoteExtPath": "SummaryToJiraComment/resources/ext.summaryToJiraComment",
44-
"dependencies": [],
45-
"styles": [],
46-
"packageFiles": [
47-
"init.js"
48-
],
49-
"messages": []
50-
}
51-
},
5240
"manifest_version": 2
5341
}

0 commit comments

Comments
 (0)