Skip to content

Commit e9af63b

Browse files
authored
fix: add User-Agent as per WMF policy (#157)
* fix: add User-Agent as per WMF policy * fix: add headers parameter to EventSource
1 parent 1081d83 commit e9af63b

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

editgroups/settings/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,4 +244,4 @@
244244
}
245245
}
246246

247-
247+
USER_AGENT = "EditGroups (https://www.wikidata.org/wiki/Wikidata:Edit_groups)"

store/stream.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,15 @@ class WikiEditStream(object):
66
def __init__(self):
77
self.url = 'https://stream.wikimedia.org/v2/stream/recentchange'
88
self.wiki = settings.WIKI_CODENAME
9+
self.headers = {
10+
"User-Agent": settings.USER_AGENT
11+
}
912

1013
def stream(self, from_time=None):
1114
url = self.url
1215
if from_time is not None:
1316
url += '?since='+from_time.isoformat().replace('+00:00', 'Z')
14-
for event in EventSource(url, timeout=30):
17+
for event in EventSource(url, timeout=30, headers=self.headers):
1518
if event.event == 'message':
1619
try:
1720
change = json.loads(event.data)

store/tests.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,7 @@ def test_stream(self):
364364
if idx > 10:
365365
break
366366
self.assertEquals('wikidatawiki', edit['wiki'])
367+
self.assertEqual(s.headers["User-Agent"], "EditGroups (https://www.wikidata.org/wiki/Wikidata:Edit_groups)")
367368

368369
class PagesTest(TestCase):
369370

0 commit comments

Comments
 (0)