Skip to content

Commit 5be5d7d

Browse files
committed
emails.backends.mediawiki: improve error handling
bubble up api error responses Bug: T412427
1 parent 44b83b5 commit 5be5d7d

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

TWLight/emails/backends/mediawiki.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,12 @@ def conn(*args, **kwargs):
5353
def _handle_maxlag(response):
5454
"""A helper method that handles maxlag retries."""
5555
data = response.json()
56-
try:
57-
if data["error"]["code"] != "maxlag":
58-
return data
59-
except KeyError:
56+
if "error" in data:
57+
error = data["error"]
58+
if error["code"] != "maxlag":
59+
msg = "{code}: {info}".format(code=error["code"], info=error["info"])
60+
raise Exception(msg)
61+
else:
6062
return data
6163

6264
retry_after = float(response.headers.get("Retry-After", 5))

0 commit comments

Comments
 (0)