chore: refactors to the config setup for testing environments

Author: WillC33

config/runtime.exs

@@ -1,5 +1,22 @@
 import Config
 
+# Default config for dev/test
+config :ambrosia,
+  port: String.to_integer(System.get_env("GEMINI_PORT", "1965")),
+  root_dir: System.get_env("ROOT_DIR", "/tmp/gemini"),
+  cert_file: System.get_env("CERT_FILE", "priv/cert.pem"),
+  key_file: System.get_env("KEY_FILE", "priv/key.pem"),
+  max_connections: String.to_integer(System.get_env("MAX_CONNECTIONS", "1000")),
+  request_timeout:
+    String.to_integer(System.get_env("REQUEST_TIMEOUT", "10000")),
+  hostname: System.get_env("HOSTNAME", "localhost"),
+  rate_limit_requests:
+    String.to_integer(System.get_env("RATE_LIMIT_REQUESTS", "10")),
+  rate_limit_window_ms:
+    String.to_integer(System.get_env("RATE_LIMIT_WINDOW_MS", "1000")),
+  max_per_ip: String.to_integer(System.get_env("MAX_PER_IP", "10")),
+  stats_interval: String.to_integer(System.get_env("STATS_INTERVAL", "30000"))
+
 if config_env() == :prod do
   hostname = System.get_env("HOSTNAME")
 
@@ -8,17 +25,6 @@ if config_env() == :prod do
   end
 
   config :ambrosia,
-    port: String.to_integer(System.get_env("GEMINI_PORT", "1965")),
-    root_dir: System.get_env("ROOT_DIR", "/app/gemini"),
-    cert_file: System.get_env("CERT_FILE", "/certs/cert.pem"),
-    key_file: System.get_env("KEY_FILE", "/certs/key.pem"),
-    max_connections:
-      String.to_integer(System.get_env("MAX_CONNECTIONS", "1000")),
-    request_timeout:
-      String.to_integer(System.get_env("REQUEST_TIMEOUT", "10000")),
     hostname: hostname,
-    rate_limit_requests:
-      String.to_integer(System.get_env("RATE_LIMIT_REQUESTS", "10")),
-    rate_limit_window_ms:
-      String.to_integer(System.get_env("RATE_LIMIT_WINDOW_MS", "1000"))
+    root_dir: System.get_env("ROOT_DIR", "/app/gemini")
 end

config/test.exs

@@ -4,4 +4,14 @@ config :logger, level: :warning
 
 config :ambrosia,
   # 100ms instead of 10 seconds for tests so they aren't taking as long to run
-  request_timeout: 100
+  request_timeout: 100,
+  port: 1965,
+  root_dir: "/tmp/gemini",
+  cert_file: "priv/cert.pem",
+  key_file: "priv/key.pem",
+  max_connections: 1000,
+  hostname: "localhost",
+  rate_limit_requests: 10,
+  rate_limit_window_ms: 1000,
+  max_per_ip: 10,
+  stats_interval: 30_000

lib/ambrosia/application.ex

@@ -103,21 +103,15 @@ defmodule Ambrosia.Application do
     hostname = System.get_env("HOSTNAME")
     env = Application.get_env(:ambrosia, :environment, :prod)
 
-    # Require hostname in production
-    if env == :prod && is_nil(hostname) do
-      raise """
-      HOSTNAME environment variable is required in production.
-      Set it to your capsule's domain name.
-      """
-    end
-
     %{
       port: Application.get_env(:ambrosia, :port, 1965),
       root_dir: Application.get_env(:ambrosia, :root_dir, "./gemini"),
       cert_file: Application.get_env(:ambrosia, :cert_file, "./certs/cert.pem"),
       key_file: Application.get_env(:ambrosia, :key_file, "./certs/key.pem"),
       max_connections: Application.get_env(:ambrosia, :max_connections, 1000),
       request_timeout: Application.get_env(:ambrosia, :request_timeout, 10_000),
+      max_per_ip: Application.get_env(:ambrosia, :max_per_ip, 10),
+      stats_interval: Application.get_env(:ambrosia, :stats_interval, 30_000),
       hostname: hostname,
       environment: env,
       # Only allow in dev/test, never in production