test: Enhanced test coverage for AzureOpenAiRuntimeHintsTests

Signed-off-by: Alex Klimenko <[email protected]>
Signed-off-by: 家娃 <[email protected]>

Author: alxkm

models/spring-ai-azure-openai/src/test/java/org/springframework/ai/azure/openai/aot/AzureOpenAiRuntimeHintsTests.java

@@ -16,28 +16,39 @@
 
 package org.springframework.ai.azure.openai.aot;
 
+import java.util.HashSet;
 import java.util.Set;
 
 import com.azure.ai.openai.OpenAIAsyncClient;
 import com.azure.ai.openai.OpenAIClient;
 import com.azure.ai.openai.models.ChatChoice;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.BeforeEach;
 
 import org.springframework.ai.aot.AiRuntimeHints;
 import org.springframework.aot.hint.RuntimeHints;
 import org.springframework.aot.hint.TypeReference;
+import org.springframework.aot.hint.MemberCategory;
 
 import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
 import static org.springframework.aot.hint.predicate.RuntimeHintsPredicates.reflection;
 import static org.springframework.aot.hint.predicate.RuntimeHintsPredicates.resource;
 
 class AzureOpenAiRuntimeHintsTests {
 
+	private RuntimeHints runtimeHints;
+
+	private AzureOpenAiRuntimeHints azureOpenAiRuntimeHints;
+
+	@BeforeEach
+	void setUp() {
+		runtimeHints = new RuntimeHints();
+		azureOpenAiRuntimeHints = new AzureOpenAiRuntimeHints();
+	}
+
 	@Test
 	void registerHints() {
-		RuntimeHints runtimeHints = new RuntimeHints();
-		AzureOpenAiRuntimeHints openAiRuntimeHints = new AzureOpenAiRuntimeHints();
-		openAiRuntimeHints.registerHints(runtimeHints, null);
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
 
 		Set<TypeReference> azureModelTypes = AiRuntimeHints.findClassesInPackage(ChatChoice.class.getPackageName(),
 				(metadataReader, metadataReaderFactory) -> true);
@@ -50,4 +61,112 @@ void registerHints() {
 		assertThat(runtimeHints).matches(resource().forResource("/azure-ai-openai.properties"));
 	}
 
+	@Test
+	void registerHintsWithNullClassLoader() {
+		// Test that registering hints with null ClassLoader works correctly
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIClient.class));
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIAsyncClient.class));
+		assertThat(runtimeHints).matches(resource().forResource("/azure-ai-openai.properties"));
+	}
+
+	@Test
+	void registerHintsWithCustomClassLoader() {
+		// Test that registering hints with a custom ClassLoader works correctly
+		ClassLoader customClassLoader = Thread.currentThread().getContextClassLoader();
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, customClassLoader);
+
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIClient.class));
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIAsyncClient.class));
+		assertThat(runtimeHints).matches(resource().forResource("/azure-ai-openai.properties"));
+	}
+
+	@Test
+	void allMemberCategoriesAreRegisteredForAzureTypes() {
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+
+		Set<TypeReference> azureModelTypes = AiRuntimeHints.findClassesInPackage(ChatChoice.class.getPackageName(),
+				(metadataReader, metadataReaderFactory) -> true);
+
+		// Verify that all MemberCategory values are registered for Azure model types
+		runtimeHints.reflection().typeHints().forEach(typeHint -> {
+			if (azureModelTypes.contains(typeHint.getType())) {
+				Set<MemberCategory> expectedCategories = Set.of(MemberCategory.values());
+				Set<MemberCategory> actualCategories = typeHint.getMemberCategories();
+				assertThat(actualCategories.containsAll(expectedCategories)).isTrue();
+			}
+		});
+	}
+
+	@Test
+	void verifySpecificAzureOpenAiClasses() {
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+
+		// Verify specific Azure OpenAI classes are registered
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIClient.class));
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIAsyncClient.class));
+		assertThat(runtimeHints).matches(reflection().onType(ChatChoice.class));
+	}
+
+	@Test
+	void emptyRuntimeHintsInitiallyContainsNoTypes() {
+		// Verify that fresh RuntimeHints instance contains no reflection hints
+		RuntimeHints emptyHints = new RuntimeHints();
+		Set<TypeReference> emptyRegisteredTypes = new HashSet<>();
+		emptyHints.reflection().typeHints().forEach(typeHint -> emptyRegisteredTypes.add(typeHint.getType()));
+
+		assertThat(emptyRegisteredTypes.size()).isEqualTo(0);
+	}
+
+	@Test
+	void multipleRegistrationCallsAreIdempotent() {
+		// Register hints multiple times and verify no duplicates
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+		int firstRegistrationCount = (int) runtimeHints.reflection().typeHints().count();
+
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+		int secondRegistrationCount = (int) runtimeHints.reflection().typeHints().count();
+
+		assertThat(firstRegistrationCount).isEqualTo(secondRegistrationCount);
+
+		// Verify resource hint registration is also idempotent
+		assertThat(runtimeHints).matches(resource().forResource("/azure-ai-openai.properties"));
+	}
+
+	@Test
+	void verifyAzureModelTypesInPackageIsNotEmpty() {
+		Set<TypeReference> azureModelTypes = AiRuntimeHints.findClassesInPackage(ChatChoice.class.getPackageName(),
+				(metadataReader, metadataReaderFactory) -> true);
+		assertThat(azureModelTypes.size()).isGreaterThan(0);
+	}
+
+	@Test
+	void verifyResourceHintIsRegistered() {
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+
+		// Verify the specific resource hint is registered
+		assertThat(runtimeHints).matches(resource().forResource("/azure-ai-openai.properties"));
+	}
+
+	@Test
+	void verifyAllRegisteredTypesHaveReflectionHints() {
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+
+		// Ensure every registered type has proper reflection hints
+		runtimeHints.reflection().typeHints().forEach(typeHint -> {
+			assertThat(typeHint.getType()).isNotNull();
+			assertThat(typeHint.getMemberCategories().size()).isGreaterThan(0);
+		});
+	}
+
+	@Test
+	void verifyClientTypesAreRegistered() {
+		azureOpenAiRuntimeHints.registerHints(runtimeHints, null);
+
+		// Verify both sync and async client types are properly registered
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIClient.class));
+		assertThat(runtimeHints).matches(reflection().onType(OpenAIAsyncClient.class));
+	}
+
 }