Invalid window id: 1006

[yuriescl]

Hi, getting this error after opening different file inside popup and trying to re-run <leader>pd:

bug.mp4

How to reproduce:

• open any file
• execute <leader>pd over a function
• it opens the popup (as expected)
• inside the popup, run :e .
• open any file (it will open inside the same popup)
• close the popup via :q
• execute <leader>pd again
• error happens:

E5108: Lua: .../share/nvim/plugged/overlook.nvim/lua/overlook/popup.lua:178: Invalid window id: 1004                                                          
stack traceback:                                                                                                                                               
        [C]: in function 'nvim_open_win'                                                                                                                       
        .../share/nvim/plugged/overlook.nvim/lua/overlook/popup.lua:178: in function 'open_and_register_window'                                                
        .../share/nvim/plugged/overlook.nvim/lua/overlook/popup.lua:35: in function 'new'                                                                      
        ...cal/share/nvim/plugged/overlook.nvim/lua/overlook/ui.lua:7: in function 'create_popup'                                                              
        ...l/share/nvim/plugged/overlook.nvim/lua/overlook/peek.lua:29: in function 'definition'                                                               
        ...al/share/nvim/plugged/overlook.nvim/lua/overlook/api.lua:40: in function 'peek_definition'                                                          
        /home/yuri/.config/nvim/lua/keybindings.lua:72: in function </home/yuri/.config/nvim/lua/keybindings.lua:71> 

[NullVoxPopuli]

I have this exact same issue

[WilliamHsieh]

i can't reproduce this error, but did found some issue when opening netrw in overlook popups, and it's now fixed in feeecfb.

Could you please check if the error still persist? if so, would you please provide minimal reproducible config, thank you.

[NullVoxPopuli]

I still have this issue -- I think it can reliably happen if I have a hover-buffer active when I

• open a file
  • hover
  • peek definition (without closing hover)
  • close buffer (I use :q<CR>
• open a different file (I use a fuzzy finder to open the file in the same buffer)
  • hover
  • peek definition
    • error!

[WilliamHsieh]

sorry still can't reproduce, does it only happen in peek_definition?

please extend from https://github.com/WilliamHsieh/overlook.nvim/blob/master/scripts/repro.lua and provide a minimal reproducible config, thank you.

[NullVoxPopuli]

is that repro starter too minimal? there are no LS providers
(I'm not familiar with Lazy, either 🙈 )

[WilliamHsieh]

the idea is that you can add the necessary plugins (as minimal as possible) to help reproduce the issue

[yuriescl]

I took repro.lua and added Python LSP, the error doesn't happen, so indeed, I understand that you can't reproduce on your side. I'll see if I can take some time later to do a more in-depth testing to figure out where the error starts happening.
thanks for the help so far!

[yuriescl]

I'm using vim-plug + nvim-lspconfig by the way.