Skip to content

Commit e57da2a

Browse files
committed
get rid of importlib use
1 parent b8c2d96 commit e57da2a

File tree

10 files changed

+14
-25
lines changed

10 files changed

+14
-25
lines changed

build/lib/data_algebra/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
Recommended packages include: Pandas, PyYAML (supplies yaml), sqlparse, and black.
1818
"""
1919

20-
import importlib
2120
import data_algebra.pandas_model
21+
import pandas
2222

2323
default_data_model = data_algebra.pandas_model.PandasModel(
24-
pd=importlib.import_module("pandas"),
24+
pd=pandas,
2525
presentation_model_name='pandas')

build/lib/data_algebra/modin_model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11

22

3-
import importlib
43
import os
54

65
import data_algebra.eval_model
@@ -23,7 +22,8 @@ def __init__(self, modin_engine=None):
2322
MODIN_ENGINE = modin_engine
2423
# https://github.com/modin-project/modin
2524
os.environ["MODIN_ENGINE"] = MODIN_ENGINE
26-
MODIN_PANDAS = importlib.import_module("modin.pandas")
25+
import modin.pandas
26+
MODIN_PANDAS = modin.pandas
2727
else:
2828
if (modin_engine is not None) and (modin_engine != MODIN_ENGINE):
2929
raise ValueError("MODIN_ENGINE already set to "

build/lib/data_algebra/pandas_base.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@
1313

1414

1515
# TODO: possibly import dask, Nvidia Rapids, or modin instead
16-
# can't do that now
17-
# https://github.com/modin-project/modin/issues/865
18-
# requires: modin, ray, distributed
19-
# pip install modin[ray]
20-
# pd = importlib.import_module("modin.pandas") # https://github.com/modin-project/modin
2116

2217
# base class for Pandas-like API realization
2318
class PandasModelBase(data_algebra.data_model.DataModel, ABC):

coverage.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,4 @@ data_algebra/yaml.py 95 11 88%
9494
TOTAL 4115 812 80%
9595

9696

97-
============================= 101 passed in 16.88s =============================
97+
============================= 101 passed in 16.91s =============================

data_algebra/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
Recommended packages include: Pandas, PyYAML (supplies yaml), sqlparse, and black.
1818
"""
1919

20-
import importlib
2120
import data_algebra.pandas_model
21+
import pandas
2222

2323
default_data_model = data_algebra.pandas_model.PandasModel(
24-
pd=importlib.import_module("pandas"),
24+
pd=pandas,
2525
presentation_model_name='pandas')

data_algebra/modin_model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11

22

3-
import importlib
43
import os
54

65
import data_algebra.eval_model
@@ -23,7 +22,8 @@ def __init__(self, modin_engine=None):
2322
MODIN_ENGINE = modin_engine
2423
# https://github.com/modin-project/modin
2524
os.environ["MODIN_ENGINE"] = MODIN_ENGINE
26-
MODIN_PANDAS = importlib.import_module("modin.pandas")
25+
import modin.pandas
26+
MODIN_PANDAS = modin.pandas
2727
else:
2828
if (modin_engine is not None) and (modin_engine != MODIN_ENGINE):
2929
raise ValueError("MODIN_ENGINE already set to "

data_algebra/pandas_base.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,6 @@
1313

1414

1515
# TODO: possibly import dask, Nvidia Rapids, or modin instead
16-
# can't do that now
17-
# https://github.com/modin-project/modin/issues/865
18-
# requires: modin, ray, distributed
19-
# pip install modin[ray]
20-
# pd = importlib.import_module("modin.pandas") # https://github.com/modin-project/modin
2116

2217
# base class for Pandas-like API realization
2318
class PandasModelBase(data_algebra.data_model.DataModel, ABC):
-122 Bytes
Binary file not shown.

dist/data_algebra-0.5.3.tar.gz

-90 Bytes
Binary file not shown.

tests/test_modin.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11

2-
import importlib
32
import pytest
43
import warnings
54

65
import data_algebra
76
from data_algebra.data_ops import *
8-
from data_algebra.modin_model import ModinModel
7+
import data_algebra.modin_model
98
import data_algebra.test_util
109

1110
modin_engine_choice = 'ray'
@@ -15,8 +14,8 @@ def test_modin():
1514
modin_pandas = None
1615
data_model = None
1716
try:
18-
modin_pandas = importlib.import_module("modin.pandas")
19-
data_model = ModinModel(modin_engine=modin_engine_choice)
17+
data_model = data_algebra.modin_model.ModinModel(modin_engine=modin_engine_choice)
18+
modin_pandas = data_algebra.modin_model.MODIN_PANDAS
2019
except:
2120
pass
2221

@@ -57,8 +56,8 @@ def test_modin_gcalc():
5756
modin_pandas = None
5857
data_model = None
5958
try:
60-
modin_pandas = importlib.import_module("modin.pandas")
61-
data_model = ModinModel(modin_engine=modin_engine_choice)
59+
data_model = data_algebra.modin_model.ModinModel(modin_engine=modin_engine_choice)
60+
modin_pandas = data_algebra.modin_model.MODIN_PANDAS
6261
except:
6362
pass
6463

0 commit comments

Comments
 (0)