Skip to content

Commit 3ab4a10

Browse files
committed
Revert rewriting rules to fix compatibility with Nova
1 parent 1d067a7 commit 3ab4a10

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

leaf-server/paper-patches/features/0062-Add-missing-rewrite-rules.patch renamed to leaf-archived-patches/work/server/0062-Add-missing-rewrite-rules.patch

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,15 @@ From: HaHaWTH <[email protected]>
33
Date: Tue, 9 Nov 2077 00:00:00 +0800
44
Subject: [PATCH] Add missing rewrite rules
55

6+
TODO: needs to check and fix it.
7+
The new added rewriting rules cause incompatible with Nova plugin (The call Registry<*>::freeze in RegistryEventsPatch#transform)
8+
It breaks kotlin reflection, makes it can't get all members of Registry class and its parent interfaces.
9+
to validate using Nova plugin:
10+
```
11+
println(net.minecraft.core.Registry::class.members.size)
12+
println(net.minecraft.core.Registry::class.java.methods.size)
13+
```
14+
615
Tracking PR: https://github.com/PaperMC/asm-utils/pull/48
716

817
diff --git a/src/main/java/io/papermc/paper/pluginremap/reflect/ReflectionRemapper.java b/src/main/java/io/papermc/paper/pluginremap/reflect/ReflectionRemapper.java

0 commit comments

Comments
 (0)