Merge branch 'soner/fix/795-protocol-fail-cancel' into 'main'

Fix #795: Protocol switch timer not cancelling on screen dismiss and memory leak

See merge request ws/client/iosapp!1000

(cherry picked from commit 3b03b37)

Author: Ginder-Singh

Windscribe/Managers/Protocols/ProtocolManager.swift

@@ -36,6 +36,7 @@ protocol ProtocolManagerType {
     func onConnectStateChange(state: NEVPNStatus)
     func scheduleTimer()
     func saveCurrentWifiNetworks()
+    func cancelFailoverTimer()
 }
 
 class ProtocolManager: ProtocolManagerType {
@@ -455,4 +456,18 @@ extension ProtocolManager {
             }
         }
     }
+
+    /// Cancels the failover countdown timer when user dismisses the protocol switch screen
+    /// This prevents automatic protocol switching after user has dismissed the dialog
+    func cancelFailoverTimer() {
+        logger.logI("ProtocolManager", "Failover timer cancelled by user - stopping countdown")
+        
+        // Reset any nextUp protocols back to normal state
+        if let nextUpProtocol = protocolsToConnectList.first(where: { $0.viewType.isNextup }) {
+            setPriority(proto: nextUpProtocol.protocolPort.protocolName, type: .normal)
+        }
+        
+        // Stop the timer
+        stopCountdownTimer()
+    }
 }

Windscribe/Modules/Popup/Connection/ProtocolSwitch/ViewModels/ProtocolSwitchViewModel.swift

@@ -176,11 +176,16 @@ final class ProtocolSwitchViewModelImpl: ProtocolSwitchViewModel, ObservableObje
     }
 
     func dismiss() {
+        // Cancel any active failover timer to prevent automatic protocol switching
+        protocolManager.cancelFailoverTimer()
         shouldDismiss = true
     }
 
     /// Handles cancel button action based on current connection state
     func cancelSelection() {
+        // Always cancel any active failover timer when user cancels
+        protocolManager.cancelFailoverTimer()
+        
         if vpnManager.isConnected() {
             // Connected state - just dismiss the dialog
             logger.logI("ProtocolSwitchViewModel", "Canceling protocol selection - connected")