Added Wintellect.Analyzers

Author: JohnWintellect

.gitignore

@@ -114,6 +114,7 @@ _UpgradeReport_Files/
 Backup*/
 UpgradeLog*.XML
 
+packages/
 
 
 ############

FF/ArgParser.cs

@@ -199,9 +199,8 @@ public Boolean Parse(String[] args)
             {
                 ss = SwitchStatus.ShowUsage;
             }
-
-            int errorArg = -1;
-            int currArg;
+            Int32 errorArg = -1;
+            Int32 currArg;
             for (currArg = 0;
                  (ss == SwitchStatus.NoError) && (currArg < args.Length);
                  currArg++)
@@ -218,9 +217,7 @@ public Boolean Parse(String[] args)
 
                     // Get the argument itself.
                     String processedArg = args[currArg].Substring(1);
-
-                    // The index into the symbol array. 
-                    int n = this.IsSwitchInArray(this.flagSymbols, processedArg);
+                    Int32 n = this.IsSwitchInArray(this.flagSymbols, processedArg);
 
                     // If it's not in the flags array, try the data array if 
                     // that array is not null.
@@ -366,17 +363,16 @@ public Boolean Parse(String[] args)
         /// <returns>
         /// The index of the switch.
         /// </returns>
-        private int IsSwitchInArray(String[] switchArray, String value)
+        private Int32 IsSwitchInArray(String[] switchArray, String value)
         {
             String valueCompare = value;
             if (this.caseSensitiveSwitches)
             {
                 valueCompare = value.ToUpperInvariant();
             }
+            Int32 retValue = -1;
 
-            int retValue = -1;
-
-            for (int n = 0; n < switchArray.Length; n++)
+            for (Int32 n = 0; n < switchArray.Length; n++)
             {
                 String currSwitch = switchArray[n];
                 if (this.caseSensitiveSwitches)
@@ -406,7 +402,7 @@ private int IsSwitchInArray(String[] switchArray, String value)
         private Boolean StartsWithSwitchChar(String value)
         {
             Boolean isSwitch = false;
-            for (int n = 0; !isSwitch && (n < this.switchChars.Length); n++)
+            for (Int32 n = 0; !isSwitch && (n < this.switchChars.Length); n++)
             {
                 if (0 != String.CompareOrdinal(value, 0, this.switchChars[n], 0, 1))
                 {

FF/FF.csproj

@@ -61,6 +61,7 @@
     <None Include="FF.ruleset">
       <SubType>Designer</SubType>
     </None>
+    <None Include="packages.config" />
   </ItemGroup>
   <ItemGroup>
     <EmbeddedResource Include="Constants.resx">
@@ -74,6 +75,9 @@
       <SubType>Designer</SubType>
     </CodeAnalysisDictionary>
   </ItemGroup>
+  <ItemGroup>
+    <Analyzer Include="packages\Wintellect.Analyzers.1.0.5.0\analyzers\dotnet\cs\Wintellect.Analyzers.dll" />
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

FF/FF.ruleset

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RuleSet Name="FF Rule Set" Description="This rule set contains all rules. Running this rule set may result in a large number of warnings being reported. Use this rule set to get a comprehensive picture of all issues in your code. This can help you decide which of the more focused rule sets are most appropriate to run for your projects." ToolsVersion="11.0">
+<RuleSet Name="FF Rule Set" Description="This rule set contains all rules. Running this rule set may result in a large number of warnings being reported. Use this rule set to get a comprehensive picture of all issues in your code. This can help you decide which of the more focused rule sets are most appropriate to run for your projects." ToolsVersion="14.0">
   <IncludeAll Action="Warning" />
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
     <Rule Id="CA1000" Action="Error" />
@@ -603,4 +603,7 @@
     <Rule Id="C6707" Action="Error" />
     <Rule Id="C6995" Action="Error" />
   </Rules>
+  <Rules AnalyzerId="Wintellect.Analyzers" RuleNamespace="Wintellect.Analyzers">
+    <Rule Id="Wintellect010" Action="None" />
+  </Rules>
 </RuleSet>

FF/FastFindArgumentParser.cs

@@ -12,64 +12,65 @@ namespace FastFind
     using System;
     using System.Collections.Generic;
     using System.Diagnostics;
+    using System.Globalization;
     using System.IO;
     using System.Text;
     using System.Text.RegularExpressions;
 
     /// <summary>
     /// Implements the command line parsing for the Fast Find program.
     /// </summary>
-    internal class FastFindArgumentParser : ArgParser
+    internal sealed class FastFindArgumentParser : ArgParser
     {
         /// <summary>
         /// The path flag.
         /// </summary>
-        private const string PathFlag = "path";
+        private const String PathFlag = "path";
 
         /// <summary>
         /// The path flag short.
         /// </summary>
-        private const string PathFlagShort = "p";
+        private const String PathFlagShort = "p";
 
         /// <summary>
         /// The use regular expressions flag.
         /// </summary>
-        private const string RegExFlag = "regex";
+        private const String RegExFlag = "regex";
 
         /// <summary>
         /// The short use regular expressions flag.
         /// </summary>
-        private const string RegExFlagShort = "re";
+        private const String RegExFlagShort = "re";
 
         /// <summary>
         /// The only files flag.
         /// </summary>
-        private const string IncludeDirectoryName = "includedir";
+        private const String IncludeDirectoryName = "includedir";
 
         /// <summary>
         /// The short only files flag short.
         /// </summary>
-        private const string IncludeDirectoryNameShort = "i";
+        private const String IncludeDirectoryNameShort = "i";
 
         /// <summary>
         /// The no statistics flag.
         /// </summary>
-        private const string NoStats = "nostats";
+        private const String NoStats = "nostats";
 
         /// <summary>
         /// The short no stats flag.
         /// </summary>
-        private const string NoStatsShort = "ns";
+        private const String NoStatsShort = "ns";
 
         /// <summary>
         /// The help flag.
         /// </summary>
-        private const string HelpFlag = "help";
+        private const String HelpFlag = "help";
 
         /// <summary>
         /// The short help flag.
         /// </summary>
-        private const string HelpFlagShort = "?";
+        private const String HelpFlagShort = "?";
 
         /// <summary>
         /// The raw patterns as they come in from the command line.
@@ -131,7 +132,7 @@ public FastFindArgumentParser()
         /// <param name="errorInfo">
         /// The string with the invalid command line option.
         /// </param>
-        public override void OnUsage(string errorInfo)
+        public override void OnUsage(String errorInfo)
         {
             ProcessModule exe = Process.GetCurrentProcess().Modules[0];
             Console.WriteLine(Constants.UsageString, exe.FileVersionInfo.FileVersion);
@@ -159,32 +160,15 @@ public override void OnUsage(string errorInfo)
         /// <returns>
         /// One of the <see cref="ArgParser.SwitchStatus"/> values.
         /// </returns>
-        protected override SwitchStatus OnSwitch(string switchSymbol, string switchValue)
+        protected override SwitchStatus OnSwitch(String switchSymbol, String switchValue)
         {
             SwitchStatus ss = SwitchStatus.NoError;
 
             switch (switchSymbol)
             {
                 case PathFlag:
                 case PathFlagShort:
-                    if (false == String.IsNullOrEmpty(this.Path))
-                    {
-                        this.errorMessage = Constants.PathMultipleSwitches;
-                        ss = SwitchStatus.Error;
-                    }
-                    else
-                    {
-                        if (Directory.Exists(switchValue))
-                        {
-                            this.Path = switchValue;
-                        }
-                        else
-                        {
-                            this.errorMessage = Constants.PathNotExist;
-                            ss = SwitchStatus.Error;
-                        }
-                    }
-
+                    ss = TestPath(switchValue);
                     break;
 
                 case RegExFlag:
@@ -225,7 +209,7 @@ protected override SwitchStatus OnSwitch(string switchSymbol, string switchValue
         /// <returns>
         /// One of the <see cref="ArgParser.SwitchStatus"/> values.
         /// </returns>
-        protected override SwitchStatus OnNonSwitch(string value)
+        protected override SwitchStatus OnNonSwitch(String value)
         {
             // Just add this to the list of patterns to search for.
             this.rawPatterns.Add(value);
@@ -257,7 +241,7 @@ protected override SwitchStatus OnDoneParse()
             else
             {
                 // Convert all the raw patterns into regular expressions.
-                for (int i = 0; i < this.rawPatterns.Count; i++)
+                for (Int32 i = 0; i < this.rawPatterns.Count; i++)
                 {
                     String thePattern = this.rawPatterns[i];
                     if (false == this.useRegEx)
@@ -278,7 +262,10 @@ protected override SwitchStatus OnDoneParse()
                         // when the user specified the -regex switch and they
                         // used a DOS wildcard pattern like *..
                         StringBuilder sb = new StringBuilder();
-                        sb.AppendFormat(Constants.InvalidRegExFmt, thePattern, e.Message);
+                        sb.AppendFormat(CultureInfo.CurrentCulture, 
+                                        Constants.InvalidRegExFmt, 
+                                        thePattern, 
+                                        e.Message);
                         this.errorMessage = sb.ToString();
                         ss = SwitchStatus.Error;
                         break;
@@ -288,5 +275,39 @@ protected override SwitchStatus OnDoneParse()
 
             return ss;
         }
+
+        /// <summary>
+        /// Isolates the checking for the path parameter.
+        /// </summary>
+        /// <param name="pathToTest">
+        /// The path value to test.
+        /// </param>
+        /// <returns>
+        /// A valid <see cref="SwitchStatus"/> value.
+        /// </returns>
+        private SwitchStatus TestPath(String pathToTest)
+        {
+            SwitchStatus ss = SwitchStatus.Error;
+            if (false == String.IsNullOrEmpty(this.Path))
+            {
+                this.errorMessage = Constants.PathMultipleSwitches;
+                ss = SwitchStatus.Error;
+            }
+            else
+            {
+                if (Directory.Exists(pathToTest))
+                {
+                    this.Path = pathToTest;
+                }
+                else
+                {
+                    this.errorMessage = Constants.PathNotExist;
+                    ss = SwitchStatus.Error;
+                }
+            }
+
+            return ss;
+        }
+
     }
 }

FF/Program.cs

@@ -29,17 +29,17 @@ internal static class Program
         /// <summary>
         /// The total number of matching files and directories.
         /// </summary>
-        private static int totalMatches;
+        private static Int64 totalMatches;
 
         /// <summary>
         /// The total number of files looked at.
         /// </summary>
-        private static int totalFiles;
+        private static Int64 totalFiles;
 
         /// <summary>
         /// The total number of directories looked at.
         /// </summary>
-        private static int totalDirectories;
+        private static Int64 totalDirectories;
 
         /// <summary>
         /// The entry point function for the program.
@@ -51,9 +51,9 @@ internal static class Program
         /// 0 - Proper execution
         /// 1 - Invalid command line.
         /// </returns>
-        internal static int Main(string[] args)
+        internal static Int32 Main(String[] args)
         {
-            int returnValue = 0;
+            Int32 returnValue = 0;
 
             Stopwatch timer = new Stopwatch();
 
@@ -98,7 +98,7 @@ internal static int Main(string[] args)
         /// <param name="args">
         /// Any additional items to include in the output.
         /// </param>
-        internal static void WriteError(string message, params Object[] args)
+        internal static void WriteError(String message, params Object[] args)
         {
             ColorWriteLine(ConsoleColor.Red, message, args);
         }
@@ -109,7 +109,7 @@ internal static void WriteError(string message, params Object[] args)
         /// <param name="message">
         /// The message to write.
         /// </param>
-        internal static void WriteError(string message)
+        internal static void WriteError(String message)
         {
             ColorWriteLine(ConsoleColor.Red, message, null);
         }
@@ -160,7 +160,7 @@ private static void ColorWriteLine(ConsoleColor color,
         /// </returns>
         private static Boolean IsNameMatch(String name)
         {
-            for (int i = 0; i < Options.Patterns.Count; i++)
+            for (Int32 i = 0; i < Options.Patterns.Count; i++)
             {
                 if (Options.Patterns[i].IsMatch(name))
                 {
@@ -185,7 +185,7 @@ private static void RecurseFiles(String directory)
 
                 Interlocked.Add(ref totalFiles, files.Length);
 
-                for (int i = 0; i < files.Length; i++)
+                for (Int32 i = 0; i < files.Length; i++)
                 {
                     String currFile = files[i];
                     if (false == Options.IncludeDirectories)
@@ -204,7 +204,7 @@ private static void RecurseFiles(String directory)
                 String[] dirs = Directory.GetDirectories(directory);
                 Interlocked.Add(ref totalDirectories, dirs.Length);
 
-                for (int i = 0; i < dirs.Length; i++)
+                for (Int32 i = 0; i < dirs.Length; i++)
                 {
                     String currDir = dirs[i];
                     if (Options.IncludeDirectories)

FF/packages.config

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="Wintellect.Analyzers" version="1.0.5.0" targetFramework="net461" />
+</packages>