Skip to content

Commit 83aaada

Browse files
[ci] Make deploys fail if the spec build fails (#8)
Our CI deploy action currently asks a server at api.csswg.org to build the spec, and then uses the response to that request as the build output. However, it does not check that the response's HTTP status code is successful, which can result in Internal Server Errors in that server being "propagated" to this spec, rather than resulting in a failed build. Similarly, fatal errors in building the spec (for invalid Bikeshed syntax, for example) would result in the list of errors being deployed. This PR fixes that by allowing `curl` to fail for non-successful HTTP status codes.
1 parent 31630ad commit 83aaada

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Build spec
1717
run: |
1818
mkdir -p out
19-
curl --retry 2 https://api.csswg.org/bikeshed/ --output out/index.html --header "Accept: text/plain, text/html" -F die-on=fatal -F file=@"index.bs"
19+
curl --retry 2 --fail https://api.csswg.org/bikeshed/ --output out/index.html --header "Accept: text/plain, text/html" -F die-on=fatal -F file=@"index.bs"
2020
2121
- name: Upload to Deno Deploy
2222
uses: denoland/deployctl@v1

0 commit comments

Comments
 (0)