Conversation
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.39.2 to 10.0.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](https://github.com/eslint/eslint/commits/HEAD/packages/js) --- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 10.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.0.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.0.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…n/eslint-10.0.0' and 'remotes/origin/dependabot/npm_and_yarn/eslint/js-10.0.1' into upgrade-ESLint-v10
Co-Authored-By: Claude
Temporarily overrides the peer dep range of eslint-plugin-react-hooks so npm resolves it against the root eslint ^10. Remove once the plugin publishes a stable release that declares eslint ^10 support. Co-Authored-By: Claude
Co-Authored-By: Claude
PR Review: ESLint v10 UpgradeThis is a clean, well-scoped dependency upgrade. Here is my analysis: What the PR does
CorrectnessThe
The lockfile is consistent. The nested Potential concernsNode.js engine range tightens significantly.
Test plan verificationThe PR description confirms:
That is the right set of gates for a dev-tooling upgrade. No application source files changed, so no additional test coverage is needed. SummaryThe approach is sound. The Verdict: Approve with one minor suggestion – verify the Node.js version in CI satisfies |
|
Verified with Node.js 22 https://github.com/Wintus/Wikipedia-Blame/actions/runs/22105343425/job/63886334710
the Node.js version in CI satisfies |
Summary
eslintto^10.0.0and@eslint/jsto^10.0.1typescript-eslintto^8.56.0(first release declaringeslint ^10peer dep support)overridesinpackage.jsonto forward the rooteslintversion toeslint-plugin-react-hooks, working around its outdated peer dep range (^3..^9) until a stable release adds^10supportTest plan
npm run lint— ESLint 10 lints cleanlynpm run build— TypeScript + Vite build passesnpm test— all 71 Vitest tests passCo-Authored-By: Claude