internal/windows: fix order of operations issue on bit check

zx2c4 · zx2c4 · commit 473347a5e6e3 · 2022-09-16T02:47:41.000+01:00
Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
diff --git a/internal/wgwindows/client_windows.go b/internal/wgwindows/client_windows.go
@@ -63,7 +63,7 @@ func (c *Client) refreshInterfaceCache() error {
 		}
 		var status, problemCode uint32
 		ret := windows.CM_Get_DevNode_Status(&status, &problemCode, devInfoData.DevInst, 0)
-		if ret != nil || (status&windows.DN_DRIVER_LOADED|windows.DN_STARTED) != windows.DN_DRIVER_LOADED|windows.DN_STARTED {
+		if ret != nil || status&(windows.DN_DRIVER_LOADED|windows.DN_STARTED) != windows.DN_DRIVER_LOADED|windows.DN_STARTED {
 			continue
 		}
 		instanceId, err := windows.SetupDiGetDeviceInstanceId(devInfo, devInfoData)

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ func (c *Client) refreshInterfaceCache() error {`
`63`	`63`	`}`
`64`	`64`	`var status, problemCode uint32`
`65`	`65`	`ret := windows.CM_Get_DevNode_Status(&status, &problemCode, devInfoData.DevInst, 0)`
`66`		`- if ret != nil \|\| (status&windows.DN_DRIVER_LOADED\|windows.DN_STARTED) != windows.DN_DRIVER_LOADED\|windows.DN_STARTED {`
	`66`	`+ if ret != nil \|\| status&(windows.DN_DRIVER_LOADED\|windows.DN_STARTED) != windows.DN_DRIVER_LOADED\|windows.DN_STARTED {`
`67`	`67`	`continue`
`68`	`68`	`}`
`69`	`69`	`instanceId, err := windows.SetupDiGetDeviceInstanceId(devInfo, devInfoData)`