ui: further reduce log viewer memory usage

zx2c4 · zx2c4 · commit 8152191277ca · 2023-04-12T13:48:55.000+02:00
Signed-off-by: Jason A. Donenfeld &lt;Jason@zx2c4.com&gt;
diff --git a/ui/src/main/java/com/wireguard/android/activity/LogViewerActivity.kt b/ui/src/main/java/com/wireguard/android/activity/LogViewerActivity.kt
@@ -158,7 +158,6 @@ class LogViewerActivity : AppCompatActivity() {
             builder.append('\n')
         }
         val ret = builder.toString().toByteArray(Charsets.UTF_8)
-        builder.clear()
         return ret
     }
 
@@ -203,7 +202,7 @@ class LogViewerActivity : AppCompatActivity() {
             var priorModified = false
             val bufferedLogLines = arrayListOf<LogLine>()
             var timeout = 1000000000L / 2 // The timeout is initially small so that the view gets populated immediately.
-            val MAX_LINES = (1 shl 17) - 1
+            val MAX_LINES = (1 shl 16) - 1
             val MAX_BUFFERED_LINES = (1 shl 14) - 1
 
             while (true) {

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,6 @@ class LogViewerActivity : AppCompatActivity() {`
`158`	`158`	`builder.append('\n')`
`159`	`159`	`}`
`160`	`160`	`val ret = builder.toString().toByteArray(Charsets.UTF_8)`
`161`		`- builder.clear()`
`162`	`161`	`return ret`
`163`	`162`	`}`
`164`	`163`
`@@ -203,7 +202,7 @@ class LogViewerActivity : AppCompatActivity() {`
`203`	`202`	`var priorModified = false`
`204`	`203`	`val bufferedLogLines = arrayListOf<LogLine>()`
`205`	`204`	`var timeout = 1000000000L / 2 // The timeout is initially small so that the view gets populated immediately.`
`206`		`- val MAX_LINES = (1 shl 17) - 1`
	`205`	`+ val MAX_LINES = (1 shl 16) - 1`
`207`	`206`	`val MAX_BUFFERED_LINES = (1 shl 14) - 1`
`208`	`207`
`209`	`208`	`while (true) {`