Skip to content

Commit 45ddd97

Browse files
rozmansizx2c4
authored andcommitted
installer: updater: introduce ARM64 MSI packages
Windows 10 ARM64 refuses to install ARM MSI. Signed-off-by: Simon Rozman <[email protected]>
1 parent 0fa8f10 commit 45ddd97

File tree

9 files changed

+186
-14
lines changed

9 files changed

+186
-14
lines changed

installer/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@
66
/x86
77
/amd64
88
/arm
9+
/arm64

installer/build.bat

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ if exist .deps\prepared goto :build
2020
rmdir /s /q .deps 2> NUL
2121
mkdir .deps || goto :error
2222
cd .deps || goto :error
23-
call :download wix-binaries.zip https://github.com/wixtoolset/wix3/releases/download/wix3112rtm/wix311-binaries.zip 2c1888d5d1dba377fc7fa14444cf556963747ff9a0a289a3599cf09da03b9e2e || goto :error
23+
call :download wix-binaries.zip https://wixtoolset.org/downloads/v3.14.0.4118/wix314-binaries.zip 34dcbba9952902bfb710161bd45ee2e721ffa878db99f738285a21c9b09c6edb || goto :error
2424
echo [+] Extracting wix-binaries.zip
2525
mkdir wix\bin || goto :error
2626
tar -xf wix-binaries.zip -C wix\bin || goto :error
@@ -38,6 +38,7 @@ if exist .deps\prepared goto :build
3838
call :msi x86 i686 x86 || goto :error
3939
call :msi amd64 x86_64 x64 || goto :error
4040
call :msi arm armv7 arm || goto :error
41+
call :msi arm64 aarch64 arm64 || goto :error
4142
if exist ..\sign.bat call ..\sign.bat
4243
if "%SigningCertificate%"=="" goto :success
4344
if "%TimestampServer%"=="" goto :success

installer/wireguard.wxs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Copyright (C) 2019 WireGuard LLC. All Rights Reserved.
66
-->
77

8-
<?if $(var.WIREGUARD_PLATFORM) = "amd64"?>
8+
<?if $(var.WIREGUARD_PLATFORM) = "amd64" Or $(var.WIREGUARD_PLATFORM) = "arm64"?>
99
<?define PlatformProgramFilesFolder = "ProgramFiles64Folder"?>
1010
<?else?>
1111
<?define PlatformProgramFilesFolder = "ProgramFilesFolder"?>
@@ -16,6 +16,8 @@
1616
<?define UpgradeCode = "62754a0a-fee9-4412-b739-e8da2e7c9405"?>
1717
<?elseif $(var.WIREGUARD_PLATFORM) = "arm"?>
1818
<?define UpgradeCode = "f90bca59-9627-431d-92b4-a5c2d9a529ff"?>
19+
<?elseif $(var.WIREGUARD_PLATFORM) = "arm64"?>
20+
<?define UpgradeCode = "7ff76099-8940-4d3e-99b9-50a3b3ca1ee9"?>
1921
<?else?>
2022
<?error Unknown platform ?>
2123
<?endif?>

updater/mksyscall.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
/* SPDX-License-Identifier: MIT
2+
*
3+
* Copyright (C) 2019-2020 WireGuard LLC. All Rights Reserved.
4+
*/
5+
6+
package updater
7+
8+
//go:generate go run golang.org/x/sys/windows/mkwinsyscall -output zsyscall_windows.go syscall_windows.go

updater/syscall_windows.go

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
/* SPDX-License-Identifier: MIT
2+
*
3+
* Copyright (C) 2019-2020 WireGuard LLC. All Rights Reserved.
4+
*/
5+
6+
package updater
7+
8+
import "golang.org/x/sys/windows"
9+
10+
const (
11+
// TODO: Push those constants upstream. golang.zx2c4.com/wireguard/tun/wintun/memmod is declaring them too. It will share the benefit.
12+
IMAGE_FILE_MACHINE_UNKNOWN = 0
13+
IMAGE_FILE_MACHINE_TARGET_HOST = 0x0001 // Useful for indicating we want to interact with the host and not a WoW guest.
14+
IMAGE_FILE_MACHINE_I386 = 0x014c // Intel 386.
15+
IMAGE_FILE_MACHINE_R3000 = 0x0162 // MIPS little-endian, 0x160 big-endian
16+
IMAGE_FILE_MACHINE_R4000 = 0x0166 // MIPS little-endian
17+
IMAGE_FILE_MACHINE_R10000 = 0x0168 // MIPS little-endian
18+
IMAGE_FILE_MACHINE_WCEMIPSV2 = 0x0169 // MIPS little-endian WCE v2
19+
IMAGE_FILE_MACHINE_ALPHA = 0x0184 // Alpha_AXP
20+
IMAGE_FILE_MACHINE_SH3 = 0x01a2 // SH3 little-endian
21+
IMAGE_FILE_MACHINE_SH3DSP = 0x01a3
22+
IMAGE_FILE_MACHINE_SH3E = 0x01a4 // SH3E little-endian
23+
IMAGE_FILE_MACHINE_SH4 = 0x01a6 // SH4 little-endian
24+
IMAGE_FILE_MACHINE_SH5 = 0x01a8 // SH5
25+
IMAGE_FILE_MACHINE_ARM = 0x01c0 // ARM Little-Endian
26+
IMAGE_FILE_MACHINE_THUMB = 0x01c2 // ARM Thumb/Thumb-2 Little-Endian
27+
IMAGE_FILE_MACHINE_ARMNT = 0x01c4 // ARM Thumb-2 Little-Endian
28+
IMAGE_FILE_MACHINE_AM33 = 0x01d3
29+
IMAGE_FILE_MACHINE_POWERPC = 0x01F0 // IBM PowerPC Little-Endian
30+
IMAGE_FILE_MACHINE_POWERPCFP = 0x01f1
31+
IMAGE_FILE_MACHINE_IA64 = 0x0200 // Intel 64
32+
IMAGE_FILE_MACHINE_MIPS16 = 0x0266 // MIPS
33+
IMAGE_FILE_MACHINE_ALPHA64 = 0x0284 // ALPHA64
34+
IMAGE_FILE_MACHINE_MIPSFPU = 0x0366 // MIPS
35+
IMAGE_FILE_MACHINE_MIPSFPU16 = 0x0466 // MIPS
36+
IMAGE_FILE_MACHINE_AXP64 = IMAGE_FILE_MACHINE_ALPHA64
37+
IMAGE_FILE_MACHINE_TRICORE = 0x0520 // Infineon
38+
IMAGE_FILE_MACHINE_CEF = 0x0CEF
39+
IMAGE_FILE_MACHINE_EBC = 0x0EBC // EFI Byte Code
40+
IMAGE_FILE_MACHINE_AMD64 = 0x8664 // AMD64 (K8)
41+
IMAGE_FILE_MACHINE_M32R = 0x9041 // M32R little-endian
42+
IMAGE_FILE_MACHINE_ARM64 = 0xAA64 // ARM64 Little-Endian
43+
IMAGE_FILE_MACHINE_CEE = 0xC0EE
44+
)
45+
46+
//sys isWow64Process2Internal(process windows.Handle, processMachine *uint16, nativeMachine *uint16) (err error) = kernel32.IsWow64Process2
47+
48+
func isWow64Process2(process windows.Handle) (processMachine, nativeMachine uint16, err error) {
49+
err = procIsWow64Process2.Find()
50+
if err != nil {
51+
return
52+
}
53+
err = isWow64Process2Internal(process, &processMachine, &nativeMachine)
54+
return
55+
}

updater/versions.go

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ package updater
88
import (
99
"errors"
1010
"fmt"
11-
"runtime"
1211
"strconv"
1312
"strings"
1413

@@ -55,17 +54,9 @@ func versionNewerThanUs(candidate string) (bool, error) {
5554
}
5655

5756
func findCandidate(candidates fileList) (*UpdateFound, error) {
58-
var arch string
59-
if runtime.GOARCH == "amd64" {
60-
arch = "amd64"
61-
} else if runtime.GOARCH == "386" {
62-
arch = "x86"
63-
} else if runtime.GOARCH == "arm" {
64-
arch = "arm"
65-
} else if runtime.GOARCH == "arm64" {
66-
arch = "arm64"
67-
} else {
68-
return nil, errors.New("Invalid GOARCH")
57+
arch, err := findArch()
58+
if err != nil {
59+
return nil, err
6960
}
7061
prefix := fmt.Sprintf(msiArchPrefix, arch)
7162
suffix := msiSuffix

updater/versions_arm.go

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/* SPDX-License-Identifier: MIT
2+
*
3+
* Copyright (C) 2019-2020 WireGuard LLC. All Rights Reserved.
4+
*/
5+
6+
package updater
7+
8+
import (
9+
"errors"
10+
11+
"golang.org/x/sys/windows"
12+
)
13+
14+
func findArch() (arch string, err error) {
15+
process := windows.CurrentProcess()
16+
_, nativeMachine, err2 := isWow64Process2(process)
17+
if err2 != nil {
18+
var isWow64 bool
19+
if windows.IsWow64Process(process, &isWow64) != nil || !isWow64 {
20+
nativeMachine = IMAGE_FILE_MACHINE_ARMNT
21+
} else {
22+
nativeMachine = IMAGE_FILE_MACHINE_ARM64
23+
}
24+
}
25+
switch nativeMachine {
26+
case IMAGE_FILE_MACHINE_ARM64:
27+
arch = "arm64"
28+
case IMAGE_FILE_MACHINE_ARMNT:
29+
arch = "arm"
30+
default:
31+
err = errors.New("Invalid GOARCH")
32+
}
33+
return
34+
}

updater/versions_default.go

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
// +build !arm
2+
3+
/* SPDX-License-Identifier: MIT
4+
*
5+
* Copyright (C) 2019-2020 WireGuard LLC. All Rights Reserved.
6+
*/
7+
8+
package updater
9+
10+
import (
11+
"errors"
12+
"runtime"
13+
)
14+
15+
func findArch() (arch string, err error) {
16+
if runtime.GOARCH == "amd64" {
17+
arch = "amd64"
18+
} else if runtime.GOARCH == "386" {
19+
arch = "x86"
20+
} else if runtime.GOARCH == "arm" {
21+
arch = "arm"
22+
} else if runtime.GOARCH == "arm64" {
23+
arch = "arm64"
24+
} else {
25+
err = errors.New("Invalid GOARCH")
26+
}
27+
return
28+
}

updater/zsyscall_windows.go

Lines changed: 52 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)