Skip to content

Commit dc5878b

Browse files
committed
manager: pitfalls: cap virtio check to min 40 for Parallels
It looks like Parallels forked NetKVM from Red Hat and changed the versioning scheme, but kept the same driver name. So we skip the warning for a floor of v40. Signed-off-by: Jason A. Donenfeld <[email protected]>
1 parent 3773020 commit dc5878b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

manager/pitfalls.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,10 @@ func pitfallVirtioNetworkDriver() {
8282
if err != nil {
8383
return
8484
}
85+
const minimumPlausibleVersion = 40 << 48
8586
const minimumGoodVersion = (100 << 48) | (85 << 32) | (104 << 16) | (20800 << 0)
8687
version := (uint64(fixedInfo.FileVersionMS) << 32) | uint64(fixedInfo.FileVersionLS)
87-
if version >= minimumGoodVersion {
88+
if version >= minimumGoodVersion || version < minimumPlausibleVersion {
8889
return
8990
}
9091
log.Println("Warning: the VirtIO network driver (NetKVM) is out of date and may cause known problems; please update to v100.85.104.20800 or later")

0 commit comments

Comments
 (0)