greatly improved string performance

Author: Joshua Wise

src/binder/bind-string.cc

@@ -5,8 +5,8 @@
 void Binder::BindString(v8::Local<v8::String> value, int index) {
 	if (!index) {index = NextAnonIndex();}
 
-	v8::String::Value utf16(value);
-	int status = sqlite3_bind_text16(handle, index, *utf16, utf16.length() * sizeof (uint16_t), bind_type);
+	v8::String::Utf8Value utf8(value);
+	int status = sqlite3_bind_text(handle, index, *utf8, utf8.length(), bind_type);
 
 	SetBindingError(status);
 }

src/util/data.cc

@@ -13,13 +13,13 @@ v8::Local<v8::Value> GetFloatJS(sqlite3_stmt* handle, int column) {
 	return Nan::New<v8::Number>(sqlite3_column_double(handle, column));
 }
 v8::Local<v8::Value> GetTextJS(sqlite3_stmt* handle, int column) {
-	const void* value = sqlite3_column_text16(handle, column);
-	int byte_count = sqlite3_column_bytes16(handle, column);
-	return v8::String::NewFromTwoByte(
+	const unsigned char* value = sqlite3_column_text(handle, column);
+	int byte_count = sqlite3_column_bytes(handle, column);
+	return v8::String::NewFromUtf8(
 		v8::Isolate::GetCurrent(),
-		static_cast<const uint16_t*>(value),
+		reinterpret_cast<const char*>(value),
 		v8::NewStringType::kNormal,
-		byte_count / sizeof (uint16_t)
+		byte_count
 	).ToLocalChecked();
 }
 v8::Local<v8::Value> GetBlobJS(sqlite3_stmt* handle, int column) {
@@ -50,7 +50,7 @@ v8::Local<v8::Value> GetValueJS(sqlite3_stmt* handle, int column) {
 v8::Local<v8::Value> GetRowJS(sqlite3_stmt* handle, int column_count) {
 	v8::Local<v8::Object> row = Nan::New<v8::Object>();
 	for (int i=0; i<column_count; ++i) {
-		Nan::Set(row, NEW_INTERNAL_STRING16(sqlite3_column_name16(handle, i)), Data::GetValueJS(handle, i));
+		Nan::Set(row, NEW_INTERNAL_STRING8(sqlite3_column_name(handle, i)), Data::GetValueJS(handle, i));
 	}
 	return row;
 }

src/util/macros.h

@@ -233,14 +233,6 @@ inline bool IS_32BIT_INT(double num) {
 		v8::NewStringType::kInternalized                                       \
 	).ToLocalChecked()
 
-// Creates a new internalized string from UTF-16 data.
-#define NEW_INTERNAL_STRING16(string)                                          \
-	v8::String::NewFromTwoByte(                                                \
-		v8::Isolate::GetCurrent(),                                             \
-		static_cast<const uint16_t*>(string),                                  \
-		v8::NewStringType::kInternalized                                       \
-	).ToLocalChecked()
-
 // Creates a new internalized string, but only works with Latin-1 characters.
 #define NEW_INTERNAL_STRING_FAST(string)                                       \
 	v8::String::NewFromOneByte(                                                \