Skip to content

Commit 1f3c3e1

Browse files
committed
Revert "Store properties dialog bounds. (eclipse-platform#1282)" fixes eclipse-platform#1895
This reverts commit 8abe1b1. The PreferenceDialog has a custom size calculation that tries to adapt to the current page. That contradicts using the the former size eclipse-platform#1895
1 parent 3ef39fa commit 1f3c3e1

File tree

3 files changed

+2
-13
lines changed

3 files changed

+2
-13
lines changed

bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: %Plugin.name
44
Bundle-SymbolicName: org.eclipse.ui.ide; singleton:=true
5-
Bundle-Version: 3.22.200.qualifier
5+
Bundle-Version: 3.22.300.qualifier
66
Bundle-Activator: org.eclipse.ui.internal.ide.IDEWorkbenchPlugin
77
Bundle-ActivationPolicy: lazy
88
Bundle-Vendor: %Plugin.providerName

bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/PropertyDialog.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717

1818
import java.util.Iterator;
1919
import org.eclipse.core.runtime.Adapters;
20-
import org.eclipse.jface.dialogs.DialogSettings;
21-
import org.eclipse.jface.dialogs.IDialogSettings;
2220
import org.eclipse.jface.dialogs.MessageDialog;
2321
import org.eclipse.jface.preference.IPreferenceNode;
2422
import org.eclipse.jface.preference.PreferenceManager;
@@ -31,10 +29,8 @@
3129
import org.eclipse.ui.PlatformUI;
3230
import org.eclipse.ui.internal.IWorkbenchHelpContextIds;
3331
import org.eclipse.ui.internal.WorkbenchMessages;
34-
import org.eclipse.ui.internal.WorkbenchPlugin;
3532
import org.eclipse.ui.model.IContributionService;
3633
import org.eclipse.ui.model.IWorkbenchAdapter;
37-
import org.osgi.framework.Bundle;
3834

3935
/**
4036
* This dialog is created and shown when 'Properties' action is performed while
@@ -184,11 +180,4 @@ protected String getContributionType() {
184180
return IContributionService.TYPE_PROPERTY;
185181
}
186182

187-
@Override
188-
protected IDialogSettings getDialogBoundsSettings() {
189-
Bundle bundle = WorkbenchPlugin.getDefault().getBundle();
190-
IDialogSettings settings = PlatformUI.getDialogSettingsProvider(bundle).getDialogSettings();
191-
String name = getClass().getSimpleName() + ".dialogBounds"; //$NON-NLS-1$
192-
return DialogSettings.getOrCreateSection(settings, name);
193-
}
194183
}

bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
22
Bundle-ManifestVersion: 2
33
Bundle-Name: %pluginName
44
Bundle-SymbolicName: org.eclipse.ui.workbench; singleton:=true
5-
Bundle-Version: 3.132.0.qualifier
5+
Bundle-Version: 3.132.100.qualifier
66
Bundle-Activator: org.eclipse.ui.internal.WorkbenchPlugin
77
Bundle-ActivationPolicy: lazy
88
Bundle-Vendor: %providerName

0 commit comments

Comments
 (0)