Fix code mining sometimes not rendering

Because of confusion between document and widget offset in some
comparison.

Fixes eclipse-platform#1170

Author: mickaelistria

bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/InlinedAnnotationDrawingStrategy.java

@@ -73,7 +73,7 @@ public void draw(Annotation annotation, GC gc, StyledText textWidget, int widget
 			}
 			InlinedAnnotationSupport support = InlinedAnnotationSupport.getSupport(textWidget);
 			inlinedAnnotation.setSupport(support);
-			if (support.isInVisibleLines(widgetOffset) && inlinedAnnotation.isFirstVisibleOffset(widgetOffset, viewer)) {
+			if (support.isInVisibleLines(inlinedAnnotation.getPosition().offset) && inlinedAnnotation.isFirstVisibleOffset(widgetOffset, viewer)) {
 				GCConfig initialGCConfig = GCConfig.fromGC(gc);
 				GCConfig annotationGCConfig = new GCConfig(color, textWidget.getBackground(), getAnnotationFont(textWidget));
 				annotationGCConfig.applyTo(gc);

bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/source/inlined/InlinedAnnotationSupport.java

@@ -219,12 +219,12 @@ private int getExclusiveBottomIndexEndOffset() {
 		/**
 		 * Return whether the given offset is in visible lines.
 		 *
-		 * @param offset the offset
+		 * @param documentOffset the document relative offset
 		 * @return <code>true</code> if the given offset is in visible lines and <code>false</code>
 		 *         otherwise.
 		 */
 		@SuppressWarnings("boxing")
-		boolean isInVisibleLines(int offset) {
+		boolean isInVisibleLines(int documentOffset) {
 			if (endOffset == null) {
 				Display display= fViewer.getTextWidget().getDisplay();
 				if (display.getThread() == Thread.currentThread()) {
@@ -233,7 +233,7 @@ boolean isInVisibleLines(int offset) {
 					display.syncExec(() -> endOffset= getExclusiveBottomIndexEndOffset());
 				}
 			}
-			return offset >= startOffset && offset <= endOffset;
+			return documentOffset >= startOffset && documentOffset <= endOffset;
 		}
 
 		/**
@@ -548,16 +548,16 @@ private AbstractInlinedAnnotation getInlinedAnnotationAtPoint(int x, int y) {
 	/**
 	 * Return whether the given offset is in visible lines.
 	 *
-	 * @param offset the offset
+	 * @param documentOffset the document offset
 	 * @return <code>true</code> if the given offset is in visible lines and <code>false</code>
 	 *         otherwise.
 	 */
-	boolean isInVisibleLines(int offset) {
+	boolean isInVisibleLines(int documentOffset) {
 		if (visibleLines == null) {
 			// case of support has been uninstalled and mining must be drawn.
 			return false;
 		}
-		return visibleLines.isInVisibleLines(offset);
+		return visibleLines.isInVisibleLines(documentOffset);
 	}