Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6e59cfc
Always inject FinishedJobs instance into ProgressServiceImpl #1887
selundqma May 15, 2024
136058f
Update for release 4.33 (#1918)
github-actions[bot] Jun 3, 2024
e1e91db
Prepare Release 4.33 (#1925)
MohananRahul Jun 4, 2024
c248879
Version Bump for 4.33 (#1926)
MohananRahul Jun 4, 2024
f29efb8
Remove API filters from 4.32 release
HeikoKlare Jun 5, 2024
64cf545
Bump jface version for 4.33 stream
HeikoKlare Jun 5, 2024
b1cc09d
Find/Replace dialog, remove ring-tone #1908
Jun 3, 2024
2ad6cac
Version bump org.eclipse.ui.workbench.texteditor for 4.33 stream
HeikoKlare Jun 5, 2024
bdee7d2
version bump org.eclipse.e4.ui.css.core, org.eclipse.e4.ui.progress
jukzi Jun 4, 2024
4dc2378
fix warning about java.lang.Class.newInstance()
jukzi Jun 4, 2024
4f6248a
Bump version of org.eclipse.e4.ui.progress
fedejeanne Jun 6, 2024
3ef39fa
ResourceInfoPage: wrap "location" #1895
jukzi Jun 5, 2024
1f3c3e1
Revert "Store properties dialog bounds. (#1282)" fixes #1895
jukzi Jun 5, 2024
1af7f4d
Don't use IFileInfo.toString() in UI, use IFileStore.toString()
iloveeclipse Jun 3, 2024
1a2cd27
Fix Link Handler Registration on macOS
BeckerWdf May 21, 2024
3dbe6a6
Version bump org.eclipse.urischeme for 4.33 stream
BeckerWdf Jun 5, 2024
8a90239
Version bump org.eclipse.ui.ide.application for 4.33 stream
BeckerWdf Jun 5, 2024
fb9f136
Version bump org.eclipse.tests.urischeme for 4.33 stream
BeckerWdf Jun 6, 2024
9dfd0f6
version bump org.eclipse.e4.ui.workbench.renderers.swt, commands
jukzi Jun 4, 2024
27a120d
fix warning about Field.isAccessible()
jukzi Jun 4, 2024
84bd7f5
Version bump org.eclipse.text.tests for 4.33 stream
vogella Jun 7, 2024
9e05ee3
Version bump org.eclipse.ui.workbench.texteditor.tests for 4.33 stream
vogella Jun 7, 2024
3a2e413
Implement a Modern Find/Replace-Overlay
Jan 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.core.commands/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.core.commands
Bundle-Version: 3.12.100.qualifier
Bundle-Version: 3.12.200.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package: org.eclipse.core.commands,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,14 +255,16 @@ public static final String getHelpContextId(Command command) {

String contextId = null;
if (method != null) {
boolean accessible = method.isAccessible();
method.setAccessible(true);
try {
contextId = (String) method.invoke(command);
} catch (Exception e) {
// do nothing
boolean accessible = method.canAccess(command);
if (method.trySetAccessible()) {
try {
contextId = (String) method.invoke(command);
} catch (Exception ignored) {
// do nothing
} finally {
method.setAccessible(accessible);
}
}
method.setAccessible(accessible);
}
return contextId;
}
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.css.core/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Bundle-SymbolicName: org.eclipse.e4.ui.css.core;singleton:=true
Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Bundle-Version: 0.14.400.qualifier
Bundle-Version: 0.14.500.qualifier
Export-Package: org.eclipse.e4.ui.css.core;x-internal:=true,
org.eclipse.e4.ui.css.core.css2;x-friends:="org.eclipse.e4.ui.css.swt.theme,org.eclipse.e4.ui.css.swt,org.eclipse.e4.ui.css.jface",
org.eclipse.e4.ui.css.core.dom;x-friends:="org.eclipse.e4.ui.css.swt,org.eclipse.ui.views.properties.tabbed,org.eclipse.ui.forms",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*******************************************************************************/
package org.eclipse.e4.ui.css.core.impl.sac;

import java.lang.reflect.InvocationTargetException;
import java.util.HashMap;
import java.util.Map;
import org.eclipse.e4.ui.css.core.SACConstants;
Expand Down Expand Up @@ -49,7 +50,11 @@ public Parser makeParser(String name) throws ClassNotFoundException, IllegalAcce
String classNameParser = parsers.get(name);
if (classNameParser != null) {
Class<?> classParser = super.getClass().getClassLoader().loadClass(classNameParser);
return (Parser) classParser.newInstance();
try {
return (Parser) classParser.getDeclaredConstructor().newInstance();
} catch (InvocationTargetException | NoSuchMethodException e) {
throw (InstantiationException) new InstantiationException(classNameParser).initCause(e);
}
}
throw new IllegalAccessException("SAC parser with name=" + name
+ " was not registered into SAC parser factory.");
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.e4.ui.progress/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-SymbolicName: org.eclipse.e4.ui.progress;singleton:=true
Bundle-Version: 0.4.400.qualifier
Bundle-Version: 0.4.600.qualifier
Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ public class ProgressServiceImpl implements IProgressService {
ProgressManager progressManager;

@Inject
@Optional
FinishedJobs finishedJobs;

@Inject
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-SymbolicName: org.eclipse.e4.ui.workbench.renderers.swt;singleton:=true
Bundle-Version: 0.16.400.qualifier
Bundle-Version: 0.16.500.qualifier
Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1254,14 +1254,15 @@ public ReflectionSupport(T instance) {
protected Object getFieldValue(Field field) {
Object value = null;
if (field != null) {
boolean accessible = field.isAccessible();
try {
field.setAccessible(true);
value = field.get(instance);
} catch (Exception exc) {
// do nothing
} finally {
field.setAccessible(accessible);
boolean accessible = field.canAccess(instance);
if (field.trySetAccessible()) {
try {
value = field.get(instance);
} catch (Exception ignored) {
// do nothing
} finally {
field.setAccessible(accessible);
}
}
}
return value;
Expand Down
11 changes: 0 additions & 11 deletions bundles/org.eclipse.jface/.settings/.api_filters

This file was deleted.

2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jface;singleton:=true
Bundle-Version: 3.34.0.qualifier
Bundle-Version: 3.34.100.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package: org.eclipse.jface,
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
Bundle-Version: 3.17.300.qualifier
Bundle-Version: 3.18.0.qualifier
Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
Bundle-ActivationPolicy: lazy
Bundle-Vendor: %providerName
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,8 @@ private OverlayPreferenceStore createDialogOverlayStore() {
ArrayList<OverlayKey> overlayKeys= new ArrayList<>();

overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_SHOW_LEADING_SPACES));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_USE_FIND_REPLACE_OVERLAY));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_FIND_REPLACE_OVERLAY_AT_BOTTOM));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_SHOW_ENCLOSED_SPACES));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_SHOW_TRAILING_SPACES));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_SHOW_LEADING_IDEOGRAPHIC_SPACES));
Expand Down Expand Up @@ -729,6 +731,8 @@ private OverlayPreferenceStore createOverlayStore() {
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE));

overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.STRING, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_CURRENT_LINE_COLOR));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_USE_FIND_REPLACE_OVERLAY));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_FIND_REPLACE_OVERLAY_AT_BOTTOM));
overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.BOOLEAN, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_CURRENT_LINE));

overlayKeys.add(new OverlayPreferenceStore.OverlayKey(OverlayPreferenceStore.INT, AbstractDecoratedTextEditorPreferenceConstants.EDITOR_TAB_WIDTH));
Expand Down Expand Up @@ -859,6 +863,15 @@ public void widgetSelected(SelectionEvent e) {
IntegerDomain lineSpaceDomain= new IntegerDomain(0, 1000);
addTextField(appearanceComposite, lineSpacing, lineSpaceDomain, 15, 0);

label= TextEditorMessages.TextEditorPreferencePage_useFindReplaceOverlay;
Preference useFindReplaceOverlay= new Preference(AbstractDecoratedTextEditorPreferenceConstants.EDITOR_USE_FIND_REPLACE_OVERLAY, label, null);
final Button useOverlay= addCheckBox(appearanceComposite, useFindReplaceOverlay, new BooleanDomain(), 0);

label= TextEditorMessages.TextEditorPreferencePage_showFindReplaceOverlayAtBottom;
Preference findReplaceOverlayAtBottom= new Preference(AbstractDecoratedTextEditorPreferenceConstants.EDITOR_FIND_REPLACE_OVERLAY_AT_BOTTOM, label, null);
final Button overlayAtBottom= addCheckBox(appearanceComposite, findReplaceOverlayAtBottom, new BooleanDomain(), 0);
createDependency(useOverlay, useFindReplaceOverlay, new Control[] { overlayAtBottom });

label= TextEditorMessages.TextEditorPreferencePage_enableWordWrap;
Preference enableWordWrap= new Preference(AbstractTextEditor.PREFERENCE_WORD_WRAP_ENABLED, label, null);
addCheckBox(appearanceComposite, enableWordWrap, new BooleanDomain(), 0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ private TextEditorMessages() {
public static String LinkedModeConfigurationBlock_DASHED_BOX;
public static String TextEditorPreferencePage_displayedTabWidth;
public static String TextEditorPreferencePage_lineSpacing;
public static String TextEditorPreferencePage_useFindReplaceOverlay;
public static String TextEditorPreferencePage_showFindReplaceOverlayAtBottom;
public static String TextEditorPreferencePage_enableWordWrap;
public static String TextEditorPreferencePage_convertTabsToSpaces;
public static String TextEditorPreferencePage_undoHistorySize;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ EditorsPlugin_internal_error=Internal Error

TextEditorPreferencePage_displayedTabWidth=Displayed &tab width:
TextEditorPreferencePage_lineSpacing=Line &spacing (extra % of font height):
TextEditorPreferencePage_useFindReplaceOverlay=Use find/replace overla&y
TextEditorPreferencePage_showFindReplaceOverlayAtBottom=&Display find/replace overlay at bottom of editor
TextEditorPreferencePage_enableWordWrap=&Enable word wrap when opening an editor
TextEditorPreferencePage_convertTabsToSpaces=&Insert spaces for tabs
TextEditorPreferencePage_undoHistorySize=&Undo history size:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,30 @@ private AbstractDecoratedTextEditorPreferenceConstants() {
* </p>
*/
public final static String EDITOR_LINE_NUMBER_RULER= "lineNumberRuler"; //$NON-NLS-1$

/**
* A named preference that controls whether the find/replace overlay is used in place of the
* dialog.
*
* <p>
* The preference value is of type <code>Boolean</code>
* </p>
*
* @since 3.18
*/
public final static String EDITOR_USE_FIND_REPLACE_OVERLAY= "useFindReplaceOverlay"; //$NON-NLS-1$

/**
* A named preference that controls whether the editor overlay to access find and replace
* functionality should be aligned to the bottom of the editor page instead of to the top.
*
* <p>
* The preference value is of type <code>Boolean</code>
* </p>
*
* @since 3.18
*/
public final static String EDITOR_FIND_REPLACE_OVERLAY_AT_BOTTOM= "findReplaceOverlayAtBottom"; //$NON-NLS-1$

/**
* A named preference that controls if the caret offset is shown in the status line.
Expand Down Expand Up @@ -723,6 +747,8 @@ private AbstractDecoratedTextEditorPreferenceConstants() {
* @param store the preference store to be initialized
*/
public static void initializeDefaultValues(IPreferenceStore store) {
store.setDefault(AbstractDecoratedTextEditorPreferenceConstants.EDITOR_USE_FIND_REPLACE_OVERLAY, true);
store.setDefault(AbstractDecoratedTextEditorPreferenceConstants.EDITOR_FIND_REPLACE_OVERLAY_AT_BOTTOM, false);
store.setDefault(AbstractDecoratedTextEditorPreferenceConstants.USE_ANNOTATIONS_PREFERENCE_PAGE, false);
store.setDefault(AbstractDecoratedTextEditorPreferenceConstants.USE_QUICK_DIFF_PREFERENCE_PAGE, false);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.ui.ide.application;singleton:=true
Bundle-Version: 1.5.400.qualifier
Bundle-Version: 1.5.500.qualifier
Bundle-Vendor: %Plugin.providerName
Bundle-Localization: plugin
Require-Bundle: org.eclipse.ui.ide;bundle-version="[3.21.0,4.0.0)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
package org.eclipse.ui.internal.ide.application.dialogs;

import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UriHandlerPreferencePage_Confirm_Handle;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UriHandlerPreferencePage_Warning_OtherApp;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UriHandlerPreferencePage_Warning_NotPossible;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UriHandlerPreferencePage_Warning_OtherApp_Confirmation;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UriHandlerPreferencePage_Warning_OtherApp_Confirmation_Description;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UriHandlerPreferencePage_Warning_OtherApp_Description;
Expand All @@ -27,6 +27,7 @@
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UrlHandlerPreferencePage_LauncherCannotBeDetermined;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UrlHandlerPreferencePage_LoadingText;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UrlHandlerPreferencePage_Page_Description;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UrlHandlerPreferencePage_RegistrationUnsupported;
import static org.eclipse.ui.internal.ide.IDEWorkbenchMessages.UrlHandlerPreferencePage_UnsupportedOperatingSystem;

import java.util.ArrayList;
Expand Down Expand Up @@ -140,6 +141,9 @@ protected Control createContents(Composite parent) {
setDataOnTableViewer(Collections.emptyList());

} else {
if (!operatingSystemRegistration.supportsRegistration()) {
setErrorMessage(UrlHandlerPreferencePage_RegistrationUnsupported);
}
setDataOnTableViewer(getLoadingSchemeInformationList());
startRegistrationReadingJob();
}
Expand Down Expand Up @@ -294,6 +298,12 @@ private void setSchemeDetails(UiSchemeInformation schemeInfo) {

private void handleCheckbox(CheckStateChangedEvent event) {
UiSchemeInformation schemeInformation = (UiSchemeInformation) event.getElement();
if (!operatingSystemRegistration.supportsRegistration()) {
messageDialogWrapper.openWarning(getShell(), UriHandlerPreferencePage_Warning_NotPossible,
UrlHandlerPreferencePage_RegistrationUnsupported);
tableViewer.setChecked(schemeInformation, false);
return;
}
if (event.getChecked() && schemeInformation.information.schemeIsHandledByOther()) {
if (operatingSystemRegistration.canOverwriteOtherApplicationsRegistration()) {
boolean answer = messageDialogWrapper.openQuestion(getShell(),
Expand All @@ -310,7 +320,7 @@ private void handleCheckbox(CheckStateChangedEvent event) {
schemeInformation.checked = false;
tableViewer.setChecked(schemeInformation, schemeInformation.checked);

messageDialogWrapper.openWarning(getShell(), UriHandlerPreferencePage_Warning_OtherApp,
messageDialogWrapper.openWarning(getShell(), UriHandlerPreferencePage_Warning_NotPossible,
NLS.bind(UriHandlerPreferencePage_Warning_OtherApp_Description,
schemeInformation.information.getHandlerInstanceLocation(),
schemeInformation.information.getName()));
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.ide/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Plugin.name
Bundle-SymbolicName: org.eclipse.ui.ide; singleton:=true
Bundle-Version: 3.22.200.qualifier
Bundle-Version: 3.22.300.qualifier
Bundle-Activator: org.eclipse.ui.internal.ide.IDEWorkbenchPlugin
Bundle-ActivationPolicy: lazy
Bundle-Vendor: %Plugin.providerName
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
package org.eclipse.ui.actions;

import java.lang.reflect.InvocationTargetException;
import java.net.URI;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;

import org.eclipse.core.filesystem.IFileInfo;
import org.eclipse.core.filesystem.IFileStore;
import org.eclipse.core.resources.IProject;
import org.eclipse.core.resources.IResource;
import org.eclipse.core.resources.IResourceRuleFactory;
Expand Down Expand Up @@ -113,11 +115,13 @@ void checkLocationDeleted(IProject project) throws CoreException {
if (!project.exists()) {
return;
}
IFileInfo location = IDEResourceInfoUtils.getFileInfo(project.getLocationURI());
URI locationURI = project.getLocationURI();
IFileInfo location = IDEResourceInfoUtils.getFileInfo(locationURI);
if (!location.exists()) {
String displayedProjectPath = toDisplayPath(locationURI);
String message = NLS.bind(
IDEWorkbenchMessages.RefreshAction_locationDeletedMessage,
project.getName(), location.toString());
project.getName(), displayedProjectPath);

final MessageDialog dialog = new MessageDialog(getShell(),
IDEWorkbenchMessages.RefreshAction_dialogTitle, // dialog
Expand All @@ -143,6 +147,11 @@ protected int getShellStyle() {
}
}

private static String toDisplayPath(URI locationURI) {
IFileStore fileStore = IDEResourceInfoUtils.getFileStore(locationURI);
return fileStore != null ? fileStore.toString() : locationURI.toString();
}

@Override
protected String getOperationMessage() {
return IDEWorkbenchMessages.RefreshAction_progressMessage;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ public class IDEWorkbenchMessages extends NLS {
public static String WorkbenchPreference_unsupportedEncoding;
public static String WorkbenchPreference_encoding_encodingMessage;

public static String UriHandlerPreferencePage_Warning_OtherApp;
public static String UriHandlerPreferencePage_Warning_NotPossible;
public static String UriHandlerPreferencePage_Warning_OtherApp_Description;

public static String UriHandlerPreferencePage_Warning_OtherApp_Confirmation;
Expand All @@ -545,6 +545,7 @@ public class IDEWorkbenchMessages extends NLS {
public static String UrlHandlerPreferencePage_Error_Reading_Scheme;
public static String UrlHandlerPreferencePage_Error_Writing_Scheme;
public static String UrlHandlerPreferencePage_UnsupportedOperatingSystem;
public static String UrlHandlerPreferencePage_RegistrationUnsupported;
public static String UrlHandlerPreferencePage_LauncherCannotBeDetermined;

// ---workspace ---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ public void widgetSelected(SelectionEvent e) {
Label locationTitle = new Label(basicInfoComposite, SWT.LEFT);
locationTitle.setText(LOCATION_TITLE);
gd = new GridData();
gd.verticalAlignment = SWT.TOP;
locationTitle.setLayoutData(gd);

locationValue = new Text(basicInfoComposite, SWT.WRAP
Expand All @@ -325,6 +326,8 @@ public void widgetSelected(SelectionEvent e) {
locationValue.setText(locationStr);
gd = new GridData();
gd.horizontalAlignment = GridData.FILL;
gd.widthHint = convertWidthInCharsToPixels(MAX_VALUE_WIDTH);
gd.grabExcessHorizontalSpace = true;
locationValue.setLayoutData(gd);
locationValue.setBackground(locationValue.getDisplay()
.getSystemColor(SWT.COLOR_WIDGET_BACKGROUND));
Expand Down Expand Up @@ -360,6 +363,7 @@ public void widgetSelected(SelectionEvent e) {
});

Button pathCopy = new Button(basicInfoComposite, SWT.PUSH);
pathCopy.setLayoutData(gd);
pathCopy.setImage(PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.IMG_TOOL_COPY));
pathCopy.setToolTipText(PATH_BUTTON_TOOLTIP);
pathCopy.addSelectionListener(new SelectionAdapter() {
Expand Down
Loading