Some Improvements

Author: Wolf49406

Process.cpp

@@ -0,0 +1,48 @@
+#include "injection.h"
+
+int GetPIDByName(const char* ProcName) {
+	PROCESSENTRY32 PE32{ 0 };
+	PE32.dwSize = sizeof(PE32);
+
+	HANDLE hSnap = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
+	if (hSnap == INVALID_HANDLE_VALUE) {
+		printf("[-] CreateToolhelp32Snapshot error: 0x%X\n", GetLastError());
+		system("pause");
+		return 0;
+	}
+
+	DWORD PID = 0;
+	BOOL bRet = Process32FirstW(hSnap, &PE32);
+	while (bRet) {
+		if (!strcmp(ProcName, _bstr_t(PE32.szExeFile))) {
+			PID = PE32.th32ProcessID;
+			break;
+		}
+
+		bRet = Process32NextW(hSnap, &PE32);
+	}
+
+	CloseHandle(hSnap);
+
+	return PID;
+}
+
+HANDLE OpenProc(const char* ProcName) {
+	int PID = GetPIDByName(ProcName);
+	if (PID == 0) {
+		printf("[-] Can't get %s PID\n", ProcName);
+		system("pause");
+		return nullptr;
+	}
+
+	printf("[+] %s PID: %d\n", ProcName, PID);
+
+	HANDLE hProc = OpenProcess(PROCESS_CREATE_THREAD | PROCESS_QUERY_INFORMATION | PROCESS_VM_OPERATION | PROCESS_VM_WRITE | PROCESS_VM_READ, FALSE, PID);
+	if (!hProc) {
+		printf("[-] OpenProcess error: 0x%X\n", GetLastError());
+		system("pause");
+		return nullptr;
+	}
+
+	return hProc;
+}

ShellJector.vcxproj

@@ -19,7 +19,7 @@
     <UseDebugLibraries>false</UseDebugLibraries>
     <PlatformToolset>v143</PlatformToolset>
     <WholeProgramOptimization>true</WholeProgramOptimization>
-    <CharacterSet>MultiByte</CharacterSet>
+    <CharacterSet>Unicode</CharacterSet>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
   <ImportGroup Label="ExtensionSettings">
@@ -35,7 +35,7 @@
     </LinkIncremental>
     <IncludePath>$(SolutionDir)Deps\include;$(VC_IncludePath);$(WindowsSDK_IncludePath);</IncludePath>
     <LibraryPath>$(SolutionDir)Deps\lib;$(VC_LibraryPath_x64);$(WindowsSDK_LibraryPath_x64)</LibraryPath>
-    <OutDir>$(MSBuildStartupDirectory)\Build\</OutDir>
+    <OutDir>Build\</OutDir>
     <IntDir>PB\</IntDir>
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
@@ -62,6 +62,7 @@
   <ItemGroup>
     <ClCompile Include="injection.cpp" />
     <ClCompile Include="main.cpp" />
+    <ClCompile Include="Process.cpp" />
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="injection.h" />

ShellJector.vcxproj.filters

@@ -17,6 +17,9 @@
     <ClCompile Include="injection.cpp">
       <Filter>Исходные файлы</Filter>
     </ClCompile>
+    <ClCompile Include="Process.cpp">
+      <Filter>Исходные файлы</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="injection.h">

injection.cpp

@@ -1,10 +1,5 @@
 #include "injection.h"
 
-struct MemoryStruct {
-	char* memory;
-	size_t size;
-};
-
 static size_t
 WriteMemoryCallback(void* contents, size_t size, size_t nmemb, void* userp) {
 	size_t realsize = size * nmemb;
@@ -44,7 +39,7 @@ static int ProgressBar(void* ptr, double TotalToDownload, double NowDownloaded,
 bool ManualMap(HANDLE hProc, const char* DllURL) {
 	printf("[DEBUG] Downloading library...\n");
 
-	struct MemoryStruct chunk;
+	struct MemoryStruct chunk {};
 	chunk.memory = (char*)malloc(1);
 	chunk.size = 0;
 

injection.h

@@ -3,7 +3,9 @@
 #include <Windows.h>
 #include <iostream>
 #include <fstream>
+#include <filesystem>
 #include <TlHelp32.h>
+#include <comdef.h>
 #include <curl/curl.h>
 
 using f_LoadLibraryA = HINSTANCE(WINAPI*)(const char* lpLibFilename);
@@ -22,5 +24,12 @@ struct MANUAL_MAPPING_DATA {
 	BOOL SEHSupport;
 };
 
+struct MemoryStruct {
+	char* memory;
+	size_t size;
+};
+
 bool ManualMap(HANDLE hProc, const char* DllURL);
+int GetPIDByName(const char* ProcName);
+HANDLE OpenProc(const char* ProcName);
 void __stdcall Shellcode(MANUAL_MAPPING_DATA* pData);

main.cpp

@@ -17,46 +17,23 @@ int main(int argc, char* argv[]) {
 		}
 	}
 
-	PROCESSENTRY32 PE32{ 0 };
-	PE32.dwSize = sizeof(PE32);
-
-	HANDLE hSnap = CreateToolhelp32Snapshot(TH32CS_SNAPPROCESS, 0);
-	if (hSnap == INVALID_HANDLE_VALUE) {
-		printf("[-] CreateToolhelp32Snapshot error: 0x%X\n", GetLastError());
-		system("PAUSE");
+	HANDLE hProc = OpenProc(ProcName);
+	if (!hProc)
 		return 0;
-	}
-
-	DWORD PID = 0;
-	BOOL bRet = Process32First(hSnap, &PE32);
-	while (bRet) {
-		if (!strcmp(ProcName, PE32.szExeFile)) {
-			PID = PE32.th32ProcessID;
-			break;
-		}
-		bRet = Process32Next(hSnap, &PE32);
-	}
-
-	CloseHandle(hSnap);
 
-	HANDLE hProc = OpenProcess(PROCESS_ALL_ACCESS, FALSE, PID);
-	if (!hProc) {
-		printf("[-] OpenProcess error: 0x%X\n", GetLastError());
-		system("PAUSE");
-		return 0;
-	}
+	printf("[+] %s Handle: %p\n", ProcName, hProc);
 
 	if (!ManualMap(hProc, DllURL)) {
 		printf("[-] Injection error\n");
 		CloseHandle(hProc);
-		system("PAUSE");
+		system("pause");
 		return 0;
 	}
 
 	CloseHandle(hProc);
 
-	printf("\n[+] Injected!\n");
-	system("PAUSE");
+	printf("[+] Injected!\n");
+	system("pause");
 
 	return 0;
 }