You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There was an issue where the code attempted to check if luac was a valid file by calling .is_file() on each defined path without specifying a file extension. On Windows, this would fail since file require an extension.
I've added .exe to the default software paths, ensuring the check works correctly on Windows systems.
Notes:
This fix has only been briefly tested on Windows. I'm not sure if the changes work on Unix systems.
I'm not sure if that would fully resolve the issue…
The root cause lies in CommandRunner::get_path(), which is used by CommandRunner::exists(). It checks whether any path returned by CommandRunner::get_all_paths() is a file. However, this check fails because none of the generated paths include a file extension, leading to errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There was an issue where the code attempted to check if luac was a valid file by calling .is_file() on each defined path without specifying a file extension. On Windows, this would fail since file require an extension.
I've added .exe to the default software paths, ensuring the check works correctly on Windows systems.
Notes:
This fix has only been briefly tested on Windows. I'm not sure if the changes work on Unix systems.