Apply suggestions from code review

Co-authored-by: Alexander Ebert <[email protected]>

Author: Cyperghost

com.woltlab.wcf/templates/shared_multiplePagesSelectionFormField.tpl

@@ -2,18 +2,20 @@
 
 {if $field->getVisibleEverywhereFieldId() !== null}
 	<script data-relocate="true">
-		const label = document.querySelector('label[for="{$field->getPrefixedId()}"]');
+		{
+			const label = document.querySelector('label[for="{$field->getPrefixedId()}"]');
 
-		document.querySelectorAll('input[name="{$field->getVisibleEverywhereFieldId()}"]').forEach((input) => {
-			input.addEventListener("change", () => {
-				setLabelText(input.value);
+			document.querySelectorAll('input[name="{$field->getVisibleEverywhereFieldId()}"]').forEach((input) => {
+				input.addEventListener("change", () => {
+					setLabelText(input.value);
+				});
 			});
-		});
 
-		function setLabelText (value) {
-			label.innerHTML = parseInt(value) === 0 ? '{unsafe:$field->getLabel()|encodeJS}' : '{unsafe:$field->getInvertedLabel()|encodeJS}';
-		}
+			function setLabelText (value) {
+				label.innerHTML = parseInt(value) === 0 ? '{unsafe:$field->getLabel()|encodeJS}' : '{unsafe:$field->getInvertedLabel()|encodeJS}';
+			}
 
-		setLabelText(document.querySelector('input[name="{$field->getVisibleEverywhereFieldId()}"]:checked').value);
+			setLabelText(document.querySelector('input[name="{$field->getVisibleEverywhereFieldId()}"]:checked').value);
+		}
 	</script>
 {/if}

wcfsetup/install/files/acp/templates/__pageObjectIDFormField.tpl

@@ -1,6 +1,6 @@
 <div class="inputAddon">
 	<input type="number" {*
-		*}step="{@$field->getStep()}" {*
+		*}step="{$field->getStep()}" {*
 		*}id="{$field->getPrefixedId()}" {*
 		*}name="{$field->getPrefixedId()}" {*
 		*}value="{$field->getValue()}"{*
@@ -30,13 +30,13 @@
 	require(['Language', 'WoltLabSuite/Core/Acp/Ui/Menu/Item/Handler'], (Language, { AcpUiMenuItemHandler }) => {
 		Language.addObject({
 			{foreach from=$pageNodeList item=pageNode}
-			{capture assign='pageObjectIDLanguageItem'}{lang __optional=true}wcf.page.pageObjectID.{@$pageNode->identifier}{/lang}{/capture}
+			{capture assign='pageObjectIDLanguageItem'}{lang __optional=true}wcf.page.pageObjectID.{$pageNode->identifier}{/lang}{/capture}
 			{if $pageObjectIDLanguageItem}
-				'wcf.page.pageObjectID.{@$pageNode->identifier}': '{@$pageObjectIDLanguageItem|encodeJS}',
+				'wcf.page.pageObjectID.{$pageNode->identifier}': '{@$pageObjectIDLanguageItem|encodeJS}',
 			{/if}
-			{capture assign='pageObjectIDLanguageItem'}{lang __optional=true}wcf.page.pageObjectID.search.{@$pageNode->identifier}{/lang}{/capture}
+			{capture assign='pageObjectIDLanguageItem'}{lang __optional=true}wcf.page.pageObjectID.search.{$pageNode->identifier}{/lang}{/capture}
 			{if $pageObjectIDLanguageItem}
-				'wcf.page.pageObjectID.search.{@$pageNode->identifier}': '{@$pageObjectIDLanguageItem|encodeJS}',
+				'wcf.page.pageObjectID.search.{$pageNode->identifier}': '{@$pageObjectIDLanguageItem|encodeJS}',
 			{/if}
 			{/foreach}
 		});