Show a user-friendly error message when RPC interactions fail

ref https://www.woltlab.com/community/thread/314577-gridview-interaction-wirft-keine-exception/

Author: BurntimeX

ts/WoltLabSuite/Core/Api/Result.ts

@@ -105,29 +105,36 @@ export async function fromInfallibleApiRequest<T = unknown>(request: () => Promi
 }
 
 function showErrorDialog(apiError: ApiError): void {
-  const code = escapeHTML(apiError.code);
-  const type = escapeHTML(apiError.type);
-  const message = apiError.message ? escapeHTML(apiError.message) : "(not set)";
-  const param = apiError.param ? "<kbd>" + escapeHTML(apiError.param) + "</kbd>" : "(not set)";
-
-  const html = `
-    <dl>
-      <dt>Unexpected server error</dt>
-      <dd><kbd>${type}</kbd></dd>
-    </dl>
-    <dl>
-      <dt>Error code</dt>
-      <dd><kbd>${code}</kbd></dd>
-    </dl>
-    <dl>
-      <dt>Parameter</dt>
-      <dd>${param}</dd>
-    </dl>
-    <dl>
-      <dt>Message</dt>
-      <dd>${message}</dd>
-    </dl>
-  `;
+  let html = "";
+  if ((!window.ENABLE_DEBUG_MODE && apiError.code === "permission_denied") || apiError.code === "assertion_failed") {
+    html = getPhrase(
+      apiError.code === "permission_denied" ? "wcf.ajax.error.permissionDenied" : "wcf.ajax.error.illegalLink",
+    );
+  } else {
+    const code = escapeHTML(apiError.code);
+    const type = escapeHTML(apiError.type);
+    const message = apiError.message ? escapeHTML(apiError.message) : "(not set)";
+    const param = apiError.param ? "<kbd>" + escapeHTML(apiError.param) + "</kbd>" : "(not set)";
+
+    html = `
+      <dl>
+        <dt>Unexpected server error</dt>
+        <dd><kbd>${type}</kbd></dd>
+      </dl>
+      <dl>
+        <dt>Error code</dt>
+        <dd><kbd>${code}</kbd></dd>
+      </dl>
+      <dl>
+        <dt>Parameter</dt>
+        <dd>${param}</dd>
+      </dl>
+      <dl>
+        <dt>Message</dt>
+        <dd>${message}</dd>
+      </dl>
+    `;
+  }
 
   const dialog = dialogFactory().fromHtml(html).asAlert();
   dialog.show(getPhrase("wcf.global.error.title"));

ts/WoltLabSuite/Core/Component/Interaction/Rpc.ts

@@ -32,18 +32,11 @@ async function handleRpcInteraction(
   }
 
   if (confirmationType == ConfirmationType.Delete) {
-    const result = await deleteObject(endpoint);
-    if (!result.ok) {
-      return;
-    }
+    (await deleteObject(endpoint)).unwrap();
   } else {
-    const result = await postObject(
-      endpoint,
-      confirmationResult.reason ? { reason: confirmationResult.reason } : undefined,
-    );
-    if (!result.ok) {
-      return;
-    }
+    (
+      await postObject(endpoint, confirmationResult.reason ? { reason: confirmationResult.reason } : undefined)
+    ).unwrap();
   }
 
   if (interactionEffect === InteractionEffect.ReloadItem || interactionEffect === InteractionEffect.ReloadPage) {

wcfsetup/install/files/js/WoltLabSuite/Core/Api/Result.js

@@ -16,6 +16,9 @@ final class PreloadPhrasesCollectingListener
 {
     public function __invoke(PreloadPhrasesCollecting $event): void
     {
+        $event->preload('wcf.ajax.error.illegalLink');
+        $event->preload('wcf.ajax.error.permissionDenied');
+
         $event->preload('wcf.button.delete.confirmMessage');
 
         $event->preload('wcf.clipboard.item.mark');